doc: clarify IncomingMessage.destroy() description - #30255
Closed
XMB5 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object.
jasnell
approved these changes
Nov 5, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lundibundi
approved these changes
Nov 23, 2019
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in c8930fb, thanks for the PR and sorry for the delay! |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 5, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
This was referenced Jul 9, 2026
This was referenced Jul 24, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State that the 'error' event is emitted on the underlying socket, not
the IncomingMessage object.
Here are the relevant parts in the code:
Here's a program that demonstrates this
Then, curl localhost:8080
The Node.js process doesn't print the error
Checklist