| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent a94b98e commit 758a17f
2 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -291,22 +291,21 @@ resolveMap.NAPTR = resolver('queryNaptr'); | |||
| 291 | 291 | resolveMap.SOA = resolver('querySoa'); | |
| 292 | 292 | ||
| 293 | 293 | ||
| 294 | - function resolve(hostname, type_, callback_) { | ||
| 295 | - var resolver, callback; | ||
| 296 | - if (typeof type_ === 'string') { | ||
| 297 | - resolver = resolveMap[type_]; | ||
| 298 | - callback = callback_; | ||
| 299 | - } else if (typeof type_ === 'function') { | ||
| 294 | + function resolve(hostname, rrtype, callback) { | ||
| 295 | + var resolver; | ||
| 296 | + if (typeof rrtype === 'string') { | ||
| 297 | + resolver = resolveMap[rrtype]; | ||
| 298 | + } else if (typeof rrtype === 'function') { | ||
| 300 | 299 | resolver = resolveMap.A; | |
| 301 | - callback = type_; | ||
| 300 | + callback = rrtype; | ||
| 302 | 301 | } else { | |
| 303 | - throw new Error('"type" argument must be a string'); | ||
| 302 | + throw new TypeError('"rrtype" argument must be a string'); | ||
| 304 | 303 | } | |
| 305 | 304 | ||
| 306 | 305 | if (typeof resolver === 'function') { | |
| 307 | 306 | return resolver(hostname, callback); | |
| 308 | 307 | } else { | |
| 309 | - throw new Error(`Unknown type "${type_}"`); | ||
| 308 | + throw new Error(`Unknown type "${rrtype}"`); | ||
| 310 | 309 | } | |
| 311 | 310 | } | |
| 312 | 311 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -91,10 +91,8 @@ assert.doesNotThrow(() => dns.setServers([])); | |||
| 91 | 91 | assert.deepStrictEqual(dns.getServers(), []); | |
| 92 | 92 | ||
| 93 | 93 | assert.throws(() => { | |
| 94 | - dns.resolve('test.com', [], common.mustNotCall()); | ||
| 95 | - }, function(err) { | ||
| 96 | - return !(err instanceof TypeError); | ||
| 97 | - }, 'Unexpected error'); | ||
| 94 | + dns.resolve('example.com', [], common.mustNotCall()); | ||
| 95 | + }, /^TypeError: "rrtype" argument must be a string$/); | ||
| 98 | 96 | ||
| 99 | 97 | // dns.lookup should accept only falsey and string values | |
| 100 | 98 | { | |
| Back | FazBrowse Home | New Git URL |
0 commit comments