FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dns: synchronize resolve() docs and code by Trott · Pull Request #13090 · nodejs/node · GitHub

/ node Public

dns: synchronize resolve() docs and code - #13090

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:typeerror
ConversationCommits (1)ChecksFiles changed
Closed

dns: synchronize resolve() docs and code#13090
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:typeerror

Conversation

Trott commented May 18, 2017

Copy link
Copy Markdown
Member

Synchronize the argument list for dns.resolve() with what's in the
documentation.

Improve the error for a bad rrtype to be a TypeError rather than an
Error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

dns

Trott added dns Issues and PRs related to the dns subsystem. dont-land-on-v4.x semver-major PRs that contain breaking changes and should be released in the next major version. labels May 18, 2017
nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label May 18, 2017

Trott commented May 20, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8204/

Trott commented May 20, 2017

Copy link
Copy Markdown
Member Author

Sole test failure is an unrelated known flaky with a fix pending.

Trott commented May 20, 2017

Copy link
Copy Markdown
Member Author

/ping @nodejs/ctc This is ready to land except that it needs another signoff from a CTC member because it is semver-major because of the change to the error message.

silverwind commented May 28, 2017

Copy link
Copy Markdown
Contributor

Can use a more descriptive commit title? I wouldn't know what this is about if it were in the changelog like it is.

Trott commented May 28, 2017

Copy link
Copy Markdown
Member Author

Can use a more descriptive commit title? I wouldn't know what this is about if it were in the changelog like it is.

I'm open to suggestions that are less than 50 characters. :-D

silverwind commented May 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

49 chars: dns: Return TypeError on invalid resolve() input

dns: return TypeError on invalid resolve() input
8fcdc9c 
Synchronize the argument list for `dns.resolve()` with what's in the
documentation.

Improve the error for a bad `rrtype` to be a `TypeError` rather than an
`Error`.

Trott commented May 28, 2017

Copy link
Copy Markdown
Member Author

Rebased, updated commit message.

New CI: https://ci.nodejs.org/job/node-test-pull-request/8352/

joaocgreis commented May 28, 2017

Copy link
Copy Markdown
Member

node-test-commit-arm-fanned failed because of a worker issue, here is another run with the same parameters: https://ci.nodejs.org/job/node-test-commit-arm-fanned/9057/

Trott removed the ctc-review label May 29, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 29, 2017
dns: return TypeError on invalid resolve() input
758a17f 
Synchronize the argument list for `dns.resolve()` with what's in the
documentation.

Improve the error for a bad `rrtype` to be a `TypeError` rather than an
`Error`.

PR-URL: nodejs#13090
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Trott commented May 29, 2017

Copy link
Copy Markdown
Member Author

Landed in 758a17f

Trott closed this May 29, 2017

Trott commented May 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

It's fine if this has to wait for Node 9.0.0 to be released, but for the record, it is the tiniest of semver majors (change in type from Error to TypeError) and I wouldn't oppose it landing in Node 8.0.0 if it's not too late. Either way is fine with me. /cc @jasnell

jasnell mentioned this pull request Oct 30, 2017
Merged
Trott deleted the typeerror branch January 13, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
silverwind silverwind approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL