Proposal: 2017-10-31, Version 9.0.0 (Current) by jasnell · Pull Request #15135 · nodejs/node · GitHub

Commits

Details

Semver-Major

[de4a749788] - (SEMVER-MAJOR) internal/util: use internal/errors.js (Sebastian Van Sande) #11301
[db2e093e05] - (SEMVER-MAJOR) assert: handle enumerable symbol keys (Ruben Bridgewater) #15169
[b0d3bec95c] - (SEMVER-MAJOR) assert: use Same-value equality in deepStrictEqual (Ruben Bridgewater) #15398
[e13d1df89b] - (SEMVER-MAJOR) assert: support custom errors (geek) #15304
[ea2e6363f2] - (SEMVER-MAJOR) assert: use SameValueZero in deepStrictEqual (Ruben Bridgewater) #15036
[c53db1e8e9] - (SEMVER-MAJOR) assert: show thrown message in doesNotThrow() (Ruslan Bekenev) #12167
[fc463639fa] - (SEMVER-MAJOR) assert: fix assert.fail with zero arguments (Ruben Bridgewater) #13974
[d731369b1d] - (SEMVER-MAJOR) async_hooks: remove deprecated APIs (Anna Henningsen) #14414
[97c43940c8] - (SEMVER-MAJOR) benchmark: cover more nextTick() code (Rich Trott) #14645
[e79a61cf80] - (SEMVER-MAJOR) buffer: buffer.transcode to use internal/errors (Weijia Wang) #16352
[9e0f771224] - (SEMVER-MAJOR) buffer: improve error messages (Weijia Wang) #14975
[70832bc353] - (SEMVER-MAJOR) build: add V8 embedder version string (Michaël Zasso) #15785
[c5eb5bfc2e] - (SEMVER-MAJOR) build: enable runtime linking (jBarz) #15286
[2062a69879] - (SEMVER-MAJOR) build: stop support building addons with VS 2013 (Michaël Zasso) #14764
[f2b01cba7b] - (SEMVER-MAJOR) child_process: defer error to next tick (Tristian Flanagan) #4670
[fe730d34ce] - (SEMVER-MAJOR) child_process: use internal/errors (Tobias Nießen) #14009
[448c4c62d2] - (SEMVER-MAJOR) child_process: do not extend result for *Sync() (Brian White) #13601
[1fcb76e8f2] - (SEMVER-MAJOR) cluster: remove deprecated property (James M Snell) #13702
[4da8b99a74] - (SEMVER-MAJOR) console: coerce label to string in console.time() (James M Snell) #14643
[ee76f3153b] - (SEMVER-MAJOR) crypto: migrate setFipsCrypto to internal/errors (James M Snell) #16428
[df8c6c3651] - (SEMVER-MAJOR) crypto: use CHECK instead in getSSLCiphers (James M Snell) #16453
[0a03e350fb] - (SEMVER-MAJOR) crypto: migrate crypto.randomBytes to internal/errors (James M Snell) #16454
[eeada6ca63] - (SEMVER-MAJOR) crypto: migrate timingSafeEqual to internal/errors (James M Snell) #16448
[a78327f48b] - (SEMVER-MAJOR) crypto: migrate setEngine to internal/errors (James M Snell) #16429
[b8bc652869] - (SEMVER-MAJOR) crypto: migrate crypto sign to internal/errors (James M Snell) #15757
[7124b466d9] - (SEMVER-MAJOR) crypto: refactor argument validation for pbkdf2 (James M Snell) #15746
[3ddc88b5c2] - (SEMVER-MAJOR) crypto: migrate Certificate to internal/errors (James M Snell) #15756
[c75f87cc4c] - (SEMVER-MAJOR) crypto: refactor the crypto module (James M Snell) #15231
[484bfa2e37] - (SEMVER-MAJOR) crypto: accept decimal Number in randomBytes (Benjamin Gruenbaum) #15130
[c39caa997c] - (SEMVER-MAJOR) deps: backport 0f1dfae from V8 upstream (Tobias Tebbi) #15362
[2780f01392] - (SEMVER-MAJOR) deps: backport b096c44 from upstream V8 (Michaël Zasso) #15785
[3d1b3df948] - (SEMVER-MAJOR) deps: update V8 to 6.2.414.32 (Michaël Zasso) #15362
[acb9b8f73c] - (SEMVER-MAJOR) deps: backport b096c44 from upstream V8 (Michaël Zasso) #15785
[d82e1075db] - (SEMVER-MAJOR) deps: update V8 to 6.1.534.36 (Michaël Zasso) #14730
[0a66b223e1] - (SEMVER-MAJOR) deps: update V8 to 6.0.286.52 (Myles Borins) #14004
[2db2857c72] - (SEMVER-MAJOR) deps: cherry-pick 6d38f89 from upstream V8 (Michaël Zasso) #13263
[bc8e4878c0] - (SEMVER-MAJOR) deps: add missing include to V8 i18n.cc (Michaël Zasso) #13263
[9b4a891ca2] - (SEMVER-MAJOR) deps: run memory hungry V8 test in exclusive mode (Michaël Zasso) #13263
[3dc8c3bed4] - (SEMVER-MAJOR) deps: update V8 to 5.9.211.32 (Michaël Zasso) #13263
[1a452f1928] - (SEMVER-MAJOR) dgram,process,util: refactor Error to TypeError (Ruben Bridgewater) #13857
[758a17f1d5] - (SEMVER-MAJOR) dns: return TypeError on invalid resolve() input (Rich Trott) #13090
[1789dcfc87] - (SEMVER-MAJOR) doc: add missing changelogs to assert docs (Ruben Bridgewater) #15036
[8ca9338655] - (SEMVER-MAJOR) doc: document missing error types (Ruben Bridgewater) #13857
[3fab9f2cd7] - (SEMVER-MAJOR) doc: EOL deprecated API and update notes (James M Snell) #13702
[602fd36d95] - (SEMVER-MAJOR) domain: remove .dispose() (Anna Henningsen) #15412
[219932a9f7] - (SEMVER-MAJOR) errors: convert 'fs' (matzavinos) #15043
[11a2ca29ba] - (SEMVER-MAJOR) errors: migrate _http_outgoing (Weijia Wang) #14735
[9cb390d899] - (SEMVER-MAJOR) errors: migrate dns to use internal/errors (Weijia Wang) #14212
[a03d8cee1f] - (SEMVER-MAJOR) errors: migrate socket_list to internal/errors (Bougarfaoui El houcine) #11356
[f67aa566a6] - (SEMVER-MAJOR) errors: migrate tls_wrap to use internal/errors (Bidisha Pyne) #13476
[b61cab2234] - (SEMVER-MAJOR) errors: port internal/fs errors to internal/errors (Gunar C. Gessner) #11317
[1698c8e165] - (SEMVER-MAJOR) errors: fix and improve error types (Ruben Bridgewater) #13857
[3e178848a5] - (SEMVER-MAJOR) errors: improve ERR_INVALID_ARG_TYPE (Ruben Bridgewater) #13730
[0ecdf29340] - (SEMVER-MAJOR) errors: migrate lib/console (mskec) #11340
[7f3f72c19b] - (SEMVER-MAJOR) errors, readline: migrate to use internal/errors.js (Scott McKenzie) #11390
[aff8d358fa] - (SEMVER-MAJOR) errors, repl: migrate to use internal/errors.js (Dan Homola) #11347
[dbfe8c4ea2] - (SEMVER-MAJOR) errors,buffer: port errors to internal/errors (starkwang) #13976
[a9f798ebcc] - (SEMVER-MAJOR) errors,http_server: migrate to use internal/errors.js (Bidisha Pyne) #13301
[a0f7284346] - (SEMVER-MAJOR) errors,process: fix error message of hrtime() (Tobias Nießen) #13739
[062071a9c3] - (SEMVER-MAJOR) errors,process: migrate to use internal/errors.js (sreepurnajasti) #13285
[28227963fa] - (SEMVER-MAJOR) errors,repl: migrate to use internal/errors.js (sreepurnajasti) #13299
[d50a802feb] - (SEMVER-MAJOR) errors,stream-transform: migrate to use internal/errors.js (sreepurnajasti) #13310
[d2913384aa] - (SEMVER-MAJOR) errors,stream_wrap: use internal/errors.js (LAKSHMI SWETHA GOPIREDDY) #13291
[473f0eff29] - (SEMVER-MAJOR) errors,url: port url errors to internal/errors (starkwang) #13963
[1609899142] - (SEMVER-MAJOR) errors,util: migrate to use internal/errors.js (Bidisha Pyne) #13293
[e5ad5456a2] - (SEMVER-MAJOR) events: migrate to internal/errors (James M Snell) #15623
[e5c290bed9] - (SEMVER-MAJOR) fs: refactor close to use destroy (Matteo Collina) #15407
[2249234fee] - (SEMVER-MAJOR) fs: invoke callbacks with undefined context (Rich Trott) #14645
[f2f391e575] - (SEMVER-MAJOR) http: send 400 bad request on parse error (mog422) #15324
[10be20a0e8] - (SEMVER-MAJOR) http: set socket timeout when socket connects (Luigi Pinca) #8895
[620ba41694] - (SEMVER-MAJOR) http: don't double-fire the req error event (fengmk2) #14659
[156549d8ff] - (SEMVER-MAJOR) http: disable OutgoingMessage pipe method (Roee Kasher) #14358
[2fa2a60721] - (SEMVER-MAJOR) http: simplify if statement (Ruben Bridgewater) #13857
[80c9ef0b6b] - (SEMVER-MAJOR) http: edit _storeHeader to check for Trailer header (Artur G Vieira) #12990
[f55ee6e24a] - (SEMVER-MAJOR) http2: make --expose-http2 flag a non-op (James M Snell) #15535
[bdfbce9241] - (SEMVER-MAJOR) http_client, errors: migrate to internal/errors (Weijia Wang) #14423
[4843c2f415] - (SEMVER-MAJOR) https: convert to using internal/errors (Rami Moshe) #15603
[4cf56ad6f2] - (SEMVER-MAJOR) inspector: migrate to internal/errors (James M Snell) #15619
[668ad44922] - (SEMVER-MAJOR) intl: unexpose Intl.v8BreakIterator (Ben Noordhuis) #15238
[c885ea727d] - (SEMVER-MAJOR) lib: deprecate fd usage for fs.truncate(Sync) (r1cebank) #15990
[095357e26e] - (SEMVER-MAJOR) lib: tweak use of internal/errors (Ruben Bridgewater) #13829
[8520e6f280] - (SEMVER-MAJOR) lib: fix urlObject parameter name in url.format (Eduardo Leggiero) #14031
[9836cf5717] - (SEMVER-MAJOR) lib: lazy instantiation of fs.Stats dates (Daniel Pihlstrom) #12818
[234353a1b8] - (SEMVER-MAJOR) lib,src: refactor buffer out of range index (larissayvette) #11296
[9d7574eef5] - (SEMVER-MAJOR) module: deprecate Module._debug (Jackson Tian) #13948
[a517466aa7] - (SEMVER-MAJOR) module: mark DEP0019 as EOL and remove compat code (Roman Reiss) #3384
[7f55349079] - (SEMVER-MAJOR) net: convert to using internal/errors (matzavinos) #14782
[b24e269a48] - (SEMVER-MAJOR) net: multiple listen() events fail silently (Eduard Bondarenko) #13149
[75a19fb379] - (SEMVER-MAJOR) net,child_process: improve naming in internal code (Anna Henningsen) #14449
[f6caeb9526] - (SEMVER-MAJOR) os: make EOL configurable and read only (XadillaX) #14622
[1f8d527e94] - (SEMVER-MAJOR) path: deprecate internal _makeLong, replace (James M Snell) #14956
[dcfbbacba8] - (SEMVER-MAJOR) path: use internal/errors.js (Sebastian Van Sande) #11319
[a253704446] - (SEMVER-MAJOR) process: make this value consistent (Rich Trott) #14645
[43e105f645] - (SEMVER-MAJOR) process: improve hrtime() error message (Rich Trott) #14324
[3129b2c035] - (SEMVER-MAJOR) process: use internal/errors in internalNextTick (Tobias Nießen) #13982
[9788e96836] - (SEMVER-MAJOR) querystring: convert to using internal/errors (Rami Moshe) #15565
[7a29f44071] - (SEMVER-MAJOR) repl: deprecate REPLServer.prototype.memory (Lance Ball) #16242
[e416b3ee36] - (SEMVER-MAJOR) repl: deprecate turnOffEditorMode (Lance Ball) #15136
[ed1ba4580b] - (SEMVER-MAJOR) repl: remove REPLServer.createContext side effects (Lance Ball) #14331
[2ca9f94e33] - (SEMVER-MAJOR) repl: make REPLServer.bufferedCommand private (Lance Ball) #13687
[3d9e7bb1d4] - (SEMVER-MAJOR) repl: remove unused function convertToContext (Nikolai Vavilov) #13434
[33b2b10b68] - (SEMVER-MAJOR) src: fix rename of entry frame in v8abbr.h (geek) #15362
[8f9e738a69] - (SEMVER-MAJOR) src: update ustack offset identifiers (geek) #15362
[205a4d2331] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 59 (Michaël Zasso) #15362
[ddc16e505b] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 58 (Michaël Zasso) #14730
[5f22375922] - (SEMVER-MAJOR) src: add support to pass flags to dlopen (Ezequiel Garcia) #12794
[784c6d40f8] - (SEMVER-MAJOR) src: use proper errors as coming from StringBytes (Anna Henningsen) #14579
[80ebb4282d] - (SEMVER-MAJOR) src: adjust windows abort behavior (Jared Kantrowitz) #13947
[db476fc8b5] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 57 (Myles Borins) #14004
[24709b2e4a] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 56 (Michaël Zasso) #13263
[6e86a6651c] - (SEMVER-MAJOR) stream: complete migration to internal/errors (Matteo Collina) #16589
[88fb359c57] - (SEMVER-MAJOR) stream: migrate _stream_readable use error codes (Ben Halverson) #15042
[db7d1339c3] - (SEMVER-MAJOR) stream: migrate to internal/errors (Ruben Bridgewater) #15665
[4536128e7c] - (SEMVER-MAJOR) stream: remove dead code (Ruben Bridgewater) #15665
[eb4940e2d2] - (SEMVER-MAJOR) string_decoder: Migrate to use internal/errors (Weijia Wang) #14682
[a7487c92e2] - (SEMVER-MAJOR) test: fix message test after V8 upgrade (Michaël Zasso) #15362
[fca7e49e44] - (SEMVER-MAJOR) test: adjust windows failed alloc test to V8 6.2 (Bartosz Sosnowski) #14730
[95c8df18f1] - (SEMVER-MAJOR) test: add test to verify ErrnoException path (Daniel Bevenius) #13958
[0d3ef5b0f8] - (SEMVER-MAJOR) test: check this value for nextTick() (Rich Trott) #14645
[c6126b1308] - (SEMVER-MAJOR) test: refactor test-fs-stat (Rich Trott) #14645
[eaaec57332] - (SEMVER-MAJOR) test: use worker.exitedAfterDisconnect consistently (James M Snell) #13702
[839faae45a] - (SEMVER-MAJOR) timers: cleanup extraneous property on Immediates (Jeremiah Senkpiel) #16355
[ce3586da31] - (SEMVER-MAJOR) timers: warn on overflowed timeout duration (Jeremiah Senkpiel) #15627
[11f7dcf91e] - (SEMVER-MAJOR) timers: do not expose .unref()._handle._list (Jeremiah Senkpiel) #8422
[4d893e093a] - (SEMVER-MAJOR) timers: Migrate to use internal/errors (Weijia Wang) #14659
[468110b327] - (SEMVER-MAJOR) tls: deprecate parseCertString & move to internal (XadillaX) #14249
[0f7c06eb2d] - (SEMVER-MAJOR) tls: fix object prototype type confusion (Ben Noordhuis) #14447
[a7dccd040d] - (SEMVER-MAJOR) tls: type checking for key, cert and ca options (Jimmy Cann) #14807
[3ccfeb483d] - (SEMVER-MAJOR) tls: migrate tls.js to use internal/errors.js (Michael Dawson) #13994
[c88ba036b4] - (SEMVER-MAJOR) url: ensure search property is consistently null vs empty (Justin Beckwith) #13606
[b1c8f15c5f] - (SEMVER-MAJOR) util: use constructor name (Ruben Bridgewater) #14886
[3b0e800f18] - (SEMVER-MAJOR) util: make util.debuglog() consistent with doc (Vse Mozhet Byt) #13841
[58831b2f24] - (SEMVER-MAJOR) uv: improvements to process.binding('uv') (James M Snell) #14933
[ef238fb485] - (SEMVER-MAJOR) v8: migrate setFlagsFromString to internal/errors (James M Snell) #16535
[b3e5c4621d] - (SEMVER-MAJOR) v8: add new to the throw statement (Ruben Bridgewater) #13857
[88e55fe5e0] - (SEMVER-MAJOR) vm: deprecate vm.runInDebugContext (Josh Gavant) #12815
[896eaf6820] - (SEMVER-MAJOR) zlib: finish migrating to internal/errors (James M Snell) #16540
[74891412f1] - (SEMVER-MAJOR) zlib: migrate to internal/errors (James M Snell) #15618

Semver-minor

[3e25e4d00f] - (SEMVER-MINOR) http: support generic Duplex streams (Anna Henningsen) #16267
[9c6f6b0633] - (SEMVER-MINOR) module: support custom paths to require.resolve() (cjihrig) #16397
[7f9eb4c29c] - (SEMVER-MINOR) util: graduate TextEncoder/TextDecoder, tests (James M Snell) #15743
[af3aa682ac] - (SEMVER-MINOR) util: add callbackify (Refael Ackermann) #12712
[36732084db] - (SEMVER-MINOR) util,assert: expose util.isDeepStrictEqual() (Rich Trott) #16084

Semver-patch

[6e86a70da2] - assert: replace many if's with if-else statement (kuroljov) #14043
[f8063d51d7] - benchmark: fix punycode test for --without-intl (Timothy Gu) #16251
[095c0de94d] - benchmark,lib,test: use braces for multiline block (Rich Trott) #13828
[8172f4547e] - buffer: move setupBufferJS to internal (Bryan English) #16391
[355523fcfb] - buffer: refactor module.exports, imports (James M Snell) #13807
[e0340af455] - buffer: fix indentation nits (Rich Trott) #14224
[65d2067936] - build: ignore empty folders in test-addons-napi (Anna Henningsen) #16380
[2875459972] - build: run linter before running tests (Joyee Cheung) #16284
[9ab648120c] - build: improve make clean (Refael Ackermann) #16372
[90640f7bf3] - build: skip bin override on windows (Hitesh Kanwathirtha) #16460
[e714c42eab] - build: fix npm install with --shared (Ben Noordhuis) #16438
[212f4b981d] - build: add lint-md-build (Daijiro Wachi) #12756
[a82401e689] - build: do not include deleted directory (Jon Moss) #16384
[aa011a111d] - Revert "build: don't add libraries when --enable-static" (Ben Noordhuis) #14893
[be63c26e8c] - build: don't add libraries when --enable-static (Daniel Bevenius) #14837
[4108072457] - build,win: set /MP separately in Debug and Release (Nikolai Vavilov) #16415
[556ebab30e] - child_process: restore exec{File}Sync error props (Michaël Zasso) #16060
[2e59ec0c2d] - child_process: fix memory leak in .fork() (Ben Noordhuis) #15679
[9bc4f86201] - crypto: make createXYZ inlineable (Matteo Collina) #16067
[43e7e8d106] - crypto: remove useless if statement (Weijia Wang) #15041
[237067d54e] - deps: manually add 9.x support to npm (Myles Borins) #16509
[0ea8ff3deb] - deps: backport 4ca695819 from npm upstream (Myles Borins) #16509
[8922bba8d1] - deps: update npm to 5.5.1 (Myles Borins) #16509
[c087502758] - deps: V8: backport b1cd96e from upstream (Ali Ijaz Sheikh) #16308
[edd78f86ac] - deps: cherry-pick e0d64dc from upstream V8 (Michaël Zasso) #16490
[cf38d2f402] - deps: cherry-pick 676c413 from upstream V8 (Michaël Zasso) #16490
[55a4d66843] - deps: cherry-pick 2c75616 from upstream V8 (Michaël Zasso) #16490
[664512678d] - Revert "deps: update V8 to 6.2.414.33" (Michaël Zasso) #16513
[d4033c1547] - deps: update V8 to 6.2.414.33 (Michaël Zasso) #16412
[801e61ad5a] - deps: cherry-pick 37a3a15c3 from V8 upstream (Franziska Hinkelmann) #16294
[34d125f16c] - deps: c-ares float, win ipv6 bad fec0 prefix (Rod Vagg) #15378
[af171b7ba2] - deps: c-ares float, manual ares_ssize_t definition (Rod Vagg) #15378
[13c74706ef] - deps: upgrade to c-ares v1.13.0 (Rod Vagg) #15378
[d0d1eba872] - deps: update license-builder & LICENSE for c-ares (Rod Vagg) #15378
[a9f125449e] - deps: upgrade to c-ares v1.12.0 (Rod Vagg) #15378
[8dce05fa71] - deps: backport rehash strings after deserialization (Yang Guo) #14345
[785a9e5a57] - deps: cherry-pick 6cb999b97b from V8 upstream (Igor Sheludko) #14188
[31349e2245] - deps: cherry-pick 3f4536894ac from V8 upstream (ochang) #13985
[0ba74dbcc6] - deps: backport c0f1ff2 from upstream V8 (Michaël Zasso) #13517
[7cdcca7623] - deps: cherry-pick 866ee63 from upstream V8 (Michaël Zasso) #13630
[8f907b6baf] - deps: update V8 to 5.9.211.37 (Michaël Zasso) #13631
[554fa24916] - deps: cherry-pick f5fad6d from upstream v8 (daniel.bevenius) #12826
[36ba9e6e0c] - deps: cherry-pick bfae9db from upstream v8 (Ben Noordhuis) #12722
[25ef9d2db6] - doc: more accurate zlib windowBits information (Anna Henningsen) #16511
[863d1922df] - doc: add link for stream.pipe() (Jon Moss) #16593
[1cdcab09f2] - doc: slightly relax 50 character rule (James M Snell) #16523
[8a9be4175b] - doc: http2.connect accepts net & tls options (Anatoli Papirovski) #16576
[6a7210edcf] - doc: add note to releases.md (Jon Moss) #16507
[737239a053] - doc: fix CHANGELOG_V8 indentation (Jon Moss) #16507
[a0f7ae6c41] - doc: remove http2 pushStream weight option (Sebastiaan Deckers) #16451
[fa939f0cf5] - doc: add dot in documentations (erwinwahyura) #16542
[24388771ea] - doc: add multiple build guide to benchmarking doc (Peter Marton) #16142
[fb477f3fa5] - doc: add missing error codes (James M Snell) #16450
[3621889c80] - doc: improve http2 documentation (Jacob Hoffman-Andrews) #16366
[278f653512] - doc: fix inconsistent server.listen documentation (Martin Michaelis) #16020
[1261b94a3f] - doc: fix unassigned deprecation code (James M Snell) #15741
[cd1b55a942] - doc: delete link to removed doc part (Vse Mozhet Byt) #15510
[a5916107dd] - doc: fix wrong history entry in deepStrictEqual (hisener) #15381
[1cdb41f287] - doc: document missing error codes (George Bezerra) #15160
[8b2c61c169] - doc: fix api docs style (Daijiro Wachi) #13970
[102e1aa4e3] - doc: fix ordering error in errors.md (Rich Trott) #13274
[33021ba2b0] - doc, win: remove note about resize (Bartosz Sosnowski) #16320
[8a8a6865c0] - doc,net: assign deprecation code (Anna Henningsen) #14576
[55d49eb3cc] - errors: replace .split() with .replace() (Rich Trott) #15545
[cef6e1c55f] - errors: refactor invalidArgType() (Rich Trott) #15544
[324aa6488f] - errors: alphabetize error codes (Jon Moss) #15083
[fa73087fcf] - errors: keep error codes in alphabetical order (Weijia Wang) #14242
[873e2f270f] - errors: add missing ERR_ prefix on util.callbackify error (James M Snell) #13604
[5f469446e1] - errors,tools: ASCIIbetical instead of alphabetical (Refael Ackermann) #15578
[fe13e0077f] - events: onceWrapper apply directly with arguments (Anatoli Papirovski) #16212
[d5fb78982a] - events: use spread function param in emit (Anatoli Papirovski) #16212
[fd166a8759] - events: return values directly in listeners (Anatoli Papirovski) #16212
[c8d4ff1d52] - events: remove unnecessary console instantiation (Anatoli Papirovski) #16212
[f61cc15c6a] - events: stricter prop & variable checks for perf (Anatoli Papirovski) #16212
[5d99a9bf65] - http: emit close as the last event in the client (Robert Nagy) #15588
[4fdd76d4d5] - http2: fix stream reading resumption (Anatoli Papirovski) #16580
[980ebd2d35] - http2: simplify mapToHeaders, stricter validation (Anatoli Papirovski) #16575
[ca82e3088d] - http2: fix several timeout related issues (Anatoli Papirovski) #16525
[3690a72347] - http2: adjust stream buffer size (Anatoli Papirovski) #16445
[b61a08ca2d] - http2: fix mapToHeaders() with single string value (Jinwoo Lee) #16458
[73533a1932] - http2: do not allow socket manipulation (Anatoli Papirovski) #16330
[47ed02cec6] - http2: fix errors in debug statements (Anatoli Papirovski) #16373
[f912080bf2] - Revert "http2: refactor error handling" (Rich Trott) #15047
[5118f31466] - https: refactor to use http internals (Bryan English) #16395
[5886e204f0] - inspector: track async stacks when necessary (Ali Ijaz Sheikh) #16308
[a6973a3811] - Revert "inspector: rewrite inspector test helper" (Anna Henningsen) #14777
[2296b677fb] - inspector: rewrite inspector test helper (Eugene Ostroukhov) #14460
[403ccb68a5] - lib: setup IPC channel before console (Nikolai Vavilov) #16562
[88799dd3da] - lib: internal/errors should not be executable (Jon Moss) #16369
[7a71cd7d0c] - lib: move duplicate spliceOne into internal/util (Weijia Wang) #16221
[33b4320cf9] - lib: refactor wrap_js_stream for ES6/readability (Anna Henningsen) #16158
[542e94cdce] - lib: move _stream_wrap into internals (Anna Henningsen) #16158
[e6dfd59be0] - lib: pass internalBinding more implicitly (Anna Henningsen) #16218
[212de3c5ec] - lib: use destructuring for some constants (Weijia Wang) #16063
[a577bde917] - lib: fix off-by-one indentation (Rich Trott) #14064
[c474f88987] - lib: fix typos (Ruben Bridgewater) #13741
[ae6c7044c8] - Revert "lib: lazy instantiation of fs.Stats dates" (Anna Henningsen) #13256
[cadc47fe07] - module: fix extension lookups for top-level main (Guy Bedford) #16526
[d853758a22] - module: fix hook module CJS dependency loading (guybedford) #16381
[44256bb0aa] - path: fix incorrect use of ERR_INVALID_ARG_TYPE (Tobias Nießen) #14011
[c5f54b1fad] - repl: remove internal frames from runtime errors (Lance Ball) #15351
[da40050b59] - repl: fix deprecation code (Ruben Bridgewater) #15668
[766506a2e9] - repl: deprecate REPLServer.parseREPLKeyword (Lance Ball)
[de61f97c3d] - src: move handle properties to prototype (Ben Noordhuis) #16482
[7c3d6ccbf2] - src: remove superfluous HandleScope (Ben Noordhuis) #16482
[a4e46df87f] - src: use uv_stream_t, not uv_stream_s (Ben Noordhuis) #16512
[2e8c04b1bb] - src: use maybe versions of methods (Tom Boutell) #16005
[1c0772444c] - src: use V8 function to get Module Namespace (Bradley Farias) #16261
[5856c836ea] - src: fix vm module for strict mode (Franziska Hinkelmann) #16487
[75f1087f49] - src: make header file self-contained (Joyee Cheung) #16518
[f0b871bada] - src: remove unused warning in node_contextify (Michaël Zasso) #16408
[e3503aca08] - src: destroy inspector agent before context (Ali Ijaz Sheikh) #16472
[3e68e4414a] - src: remove empty comment in node_http2.h (Daniel Bevenius) #16400
[6971f0292a] - src: remove unused include in tty_wrap.h (Daniel Bevenius) #16379
[a9f50842f6] - src: fix http2 debug build errors (Daniel Bevenius) #16432
[f1d6b04ac9] - src: use new V8 API in vm module (Franziska Hinkelmann) #16293
[2146c88bc7] - src: fix NewContext for --without-intl (Timothy Gu) #16251
[a84c3be075] - src: unset NODE_VERSION_IS_RELEASE (Anna Henningsen) #14005
[1b54371c50] - stream: use more explicit statements (Ruben Bridgewater) #13863
[203b548381] - test: add block scoping to test-assert-deep (Rich Trott) #16532
[83b8474e64] - test: update test-timers-block-eventloop.js (zhangzifa) #16314
[201ecef767] - test: include actual value in assertion message (Matthew Cantelon) #15935
[a70ef362ef] - test: replace fixturesDir in test-tls-connect (Casie Lynch) #15849
[1906df1b29] - test: use fixtures module (Iryna Yaremtso) #15901
[51637574da] - test: add details in assertions in test-vm-context (Vladimir Ilic) #16116
[4ed152ea8a] - test: increase fs.exists coverage (Nigel Kibodeaux) #15963
[6ff2909ef6] - test: use fixtures module in test-fs-realpath.js (Raphael Rheault) #15904
[64aded33ef] - test: use fixtures module (Scott J Beck) #15843
[eefee3e9a6] - test: imporove assert messages (Hadis-Fard) #16021
[65b8d2133d] - test: show values instead of assertion message (Cheyenne Arrowsmith) #15979
[4eaf1fc0f8] - test: include values in assertion messages (nhoel) #15996
[98eab4a461] - test: use process.features.debug in common module (Rich Trott) #16537
[2f47b6869a] - test: use common.buildType in repl-domain-abort (Rich Trott) #16538
[502563b277] - test: skip test-process-config if no config.gypi (Gibson Fahnestock) #16436
[c66e5551df] - test: use fixtures module in tls-handshake-error (Mark Walker) #15939
[363091dea5] - test: add failing vm tests to known_issues (Michaël Zasso) #16410
[2be9198097] - test: change tmp directories prefix (Refael Ackermann) #16372
[9702ac5088] - test: add test for WrapStream readStop (Ashish Kaila) #16356
[a37a0ad5f6] - test: add test for prop interceptors on sandbox (Michaël Zasso) #16409
[d653f03c0e] - test: allow tests to pass without internet (Daniel Bevenius) #16255
[ed116dc3c6] - test: fix test for inherited properties on vm (Franziska Hinkelmann) #16411
[438e7fdaf2] - test: remove --harmony-sharedarraybuffer usage (Ben Smith) #16343
[cd5ee52d70] - test: add tests for eslint rules (Teddy Katz) #16138
[16ed116203] - test: clean up string concat in dlopen-ping-pong (agilbert) #15820
[2e215f169a] - test: fix and refactor test-http-invalid-urls (Rich Trott) #15678
[44d486500d] - test: increase coverage for internal/errors.js (Weijia Wang) #15044
[467385a49b] - test: use invalid host according to RFC2606 (Tobias Nießen) #14863
[f417add1f4] - test: add test-benchmark-zlib (Rich Trott) #14763
[3566195196] - test: replace concatenation with template literals (xeodou) #14281
[b923b9dee1] - test: replace string concat in test-child-process-constructor (mac-haojin) #14283
[2a621d4051] - test: validate more properties in expectsError (Ruben Bridgewater) #14058
[5ffb5b6fce] - test: improve the test common documentation (Ruben Bridgewater) #14148
[1b2733f272] - test: common.expectsError should be a must call (Ruben Bridgewater) #14088
[d69ecc6f51] - Revert "test: improve test-process-kill-null for Windows" (Refael Ackermann) #14142
[d6fece1436] - test: add optional throw fn to expectsError (Ruben Bridgewater) #14089
[44483b6898] - test: improve test-process-kill-null for Windows (starkwang) #14099
[5723b5dbbc] - tls: improve TLSSocket & Server performance (Anatoli Papirovski) #15575
[1403d28e7d] - tls: re-allow falsey option values (Anna Henningsen) #15131
[5723c4c5f0] - tls: replace forEach with for (Brian White) #15053
[193926ecab] - tls,doc: fix unallocated deprecation code (James M Snell) #15534
[e2ce1307ed] - tools: modernize license2rtf (Tobias Nießen) #16220
[9d768504d2] - tools: replace loop with padStart (Tobias Nießen) #16220
[22882d4094] - tools: fix cpplint.py when path contains non-ascii (sharkfisher) #16047
[748f5d848f] - tools: no trailing slash in ignore patterns (Refael Ackermann) #16372
[76b8803630] - tools: add eslint rule for documented errors (James M Snell) #16450
[a399881773] - tools: add make lint-md-clean (Daijiro Wachi) #12756
[f1329543d6] - tools: add lint-md command in Makefile (Daijiro Wachi) #12756
[92dff06122] - tools: use remark-preset-lint-node in .remarkrc (Daijiro Wachi) #12756
[2e1d092ff1] - tools: introduce remark-preset-lint-node (Daijiro Wachi) #12756
[503342e4e7] - tools: introduce remark-cli@3.0.1 (Daijiro Wachi) #12756
[50fe1a8409] - tools, benchmark: test util benchmark (Sarah Meyer) #16050
[fe8297ca92] - util: expand test coverage for util.deprecate (Ashish Kaila) #16305
[44f5523260] - v8: fix stack overflow in recursive method (Ben Noordhuis) #12460
[241eb6122e] - zlib: gracefully set windowBits from 8 to 9 (Myles Borins) #16511
[2421984727] - zlib: check cleanup return values (Anna Henningsen) #14673
[add4b0ab8c] - zlib: improve performance (Brian White) #13322

we may want to drop e5dc934 from v9.x-staging until #14161 is sorted out

RC.0 Build Underway: https://ci-release.nodejs.org/job/iojs+release/2125/
(not everyone will be able to access that link)

Why are we removing 7?

For the same reason 5 is not listed. The changelogs are still there and accessible

@jasnell can you include the list of commits here as it currently stands.

Yes. Will be updating this later on today with a plan towards having a new RC. It'll likely be later this afternoon as I'm waiting on the security release to be finished before I start on it.

All @nodejs/collaborators @nodejs/TSC ... I will be updating from master one final time tomorrow before working on generating and testing the release binaries. The release will happen on Tuesday.

@nodejs/build ... Heads up :)

#16589 should get in before release to ease compatibility with future readable-stream releases.

I would like to get a bunch of the http2 fixes in if possible, since they're pretty major. #16575, #16525 and #16580

That said, it's not a must :) so depends on timing

@nodejs/collaborators @nodejs/tsc ... definitely last call. I will be doing one final rebase from master this afternoon after noon pacific time (just over one hour from now). Unless it is an absolutely critical bug fix, if it doesn't land by noon, it won't make it in to 9.0.0

@nodejs/collaborators @nodejs/tsc ... I've completed what should be the final update. I will build a final RC in the morning, do some testing, then will build the release binaries by end of day, with intent of promoting those first thing tuesday morning. Please take one final look.

Oh, sorry. I completely forgot to land #16318

As discussed in #15454 (comment) and in the TSC meeting this should be part of the v9.0 release.

edit: landed in 23a3911

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/11094/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1036/

PR-URL should be #14333

@jasnell you wanted confirmation that #16130 didn't have anything that would prevent it from landing as semver-minor after 9.0.0 goes out (i.e. so there's no rush to bundle it here). This is that confirmation, and if I'm wrong, then we'll force it to be semver-minor!

A handful of concerning fails on CITGM

Most alarming is a module resolution failure in david on all platforms

Other less worrying problems include:

zeromq on windows

1 failing
   1) socket.monitor should read multiple events on monitor interval:
      Uncaught AssertionError: expected 7 to be within 0..5
       at Assertion.fail (node_modules\should\cjs\should.js:265:17)
       at Assertion.value [as within] (node_modules\should\cjs\should.js:340:19)
       at exports.Socket.<anonymous> (test\socket.monitor.js:103:22)
       at Object.self._zmq.onMonitorEvent (lib\index.js:543:12)

ws on osx
- fixed downstream [test] update tests to support Node.js 9.x websockets/ws#1225
shot on all platform is reporting a memory leak

       undefinedadded 190 packages in 23.23s
 > shot@4.0.3 test /Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/citgm_tmp/2d905b84-8e9e-4015-ba29-ec9013f618ba/shot
 > lab -a code -t 100 -L
   
   ............................................
 44 tests complete
 Test duration: 431 ms
 Assertions count: 0 (verbosity: 0.00)
 The following leaks were detected:SharedArrayBuffer, Atomics
 Coverage: 100.00%
 Linting results: No issues
 npm ERR! Test failed.  See above for more details.

Should tools/remark-cli be added to LICENSE (i.e. as we do for tools/eslint)?

@jasnell please do not release without including

#16637 ~ add license for remark-cli
#16634 ~ revert broken changes to module resolution algorithm

The shot failures aren't real. SharedArrayBuffer and Atomics are globals that just haven't been whitelisted by lab yet (hapijs/lab#748).

Build is failing on Windows. Tracking it down now.

@jasnell I’d assume that’s #16639?

Yep. Awesome, hadn't seen that pr yet. I may just drop the errant commit then

…

On Oct 31, 2017 07:41, "Anna Henningsen" ***@***.***> wrote: @jasnell <https://github.com/jasnell> I’d *assume* that’s #16639 <#16639>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2ec3uzo0BewqV7LQR-OM7qPHd5T2Vks5sxzGBgaJpZM4PKZRg> .

This is currently waiting on #16634 and the 8.9.0 release. 8.9.0 needs to go out first so that I can update the changelog since there is some overlap in the commits.

New CI: https://ci.nodejs.org/job/node-test-pull-request/11120/
New CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1049/

Once 8.9.0 is released, I will update the changelog in this then proceed with the release.

@gibfahn ... please ping me here once 8.9.0 is out :-)

* Older experimental APIs have been removed. [[`d731369b1d`](d731369b1d)] [#14414](#14414) * **Errors** * Improvements have been made to `buffer` module error messages. * The assignment of static error codes to Node.js error continues: * `buffer` * `child_process` * `console` * `crypto` * `dns` * `events` * `fs` * `http` * `inspector` * `net` * `path` * `process` * `querystring` * `readline` * `repl` * `streams` * `string_decoder` * `timers` * `tls` * `url` * `util` * `v8` * `zlib` * **Child Processes** * Errors are emitted on process nextTick. * **Domains** * The long-deprecated `.dispose()` method has been removed. * **fs** * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`. * `fs` module callbacks are now invoked with an undefined context. * **HTTP/1** * A 400 Bad Request response will now be sent when parsing fails. * Socket timeout will be set when the socket connects. * A bug causing the request `'error'` event to fire twice was fixed. * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`. * **Intl** * The deprecated `Intl.v8BreakIterator` has been removed. * **Modules** * The `require.resolve()` method now supports using custom lookup paths. * **OS** * The `os.EOL` property is now read-only. * **Timers** * `setTimeout()` will emit a warning if the timeout is larger that the maximum 32-bit unsigned integer.

Release CI: https://ci-release.nodejs.org/job/iojs+release/2189/

@jasnell #16630 → http://nodejs.org/dist/v8.9.0/, blog post nodejs/nodejs.org#1436

PR-URL: #15135

Refs: nodejs/node#15135

@jasnell armv6l binaries are in staging, can you promote please?

* Older experimental APIs have been removed. [[`d731369b1d`](d731369b1d)] [#14414](#14414) * **Errors** * Improvements have been made to `buffer` module error messages. * The assignment of static error codes to Node.js error continues: * `buffer` * `child_process` * `console` * `crypto` * `dns` * `events` * `fs` * `http` * `inspector` * `net` * `path` * `process` * `querystring` * `readline` * `repl` * `streams` * `string_decoder` * `timers` * `tls` * `url` * `util` * `v8` * `zlib` * **Child Processes** * Errors are emitted on process nextTick. * **Domains** * The long-deprecated `.dispose()` method has been removed. * **fs** * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`. * `fs` module callbacks are now invoked with an undefined context. * **HTTP/1** * A 400 Bad Request response will now be sent when parsing fails. * Socket timeout will be set when the socket connects. * A bug causing the request `'error'` event to fire twice was fixed. * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`. * **Intl** * The deprecated `Intl.v8BreakIterator` has been removed. * **Modules** * The `require.resolve()` method now supports using custom lookup paths. * **OS** * The `os.EOL` property is now read-only. * **Timers** * `setTimeout()` will emit a warning if the timeout is larger that the maximum 32-bit unsigned integer.

jasnell added the wip Issues and PRs that are still a work in progress. label Sep 1, 2017

jasnell changed the title [WIP] 2017-10-31, Version 9.0.0 (Current) [WIP] Proposal: 2017-10-31, Version 9.0.0 (Current) Sep 1, 2017

nodejs deleted a comment Sep 10, 2017

jasnell force-pushed the v9.0.0-proposal branch from 849147d to 832f8dc Compare September 25, 2017 20:59

jasnell force-pushed the v9.0.0-proposal branch 2 times, most recently from 25f6731 to 6891ac2 Compare October 17, 2017 22:52

jasnell changed the title [WIP] Proposal: 2017-10-31, Version 9.0.0 (Current) Proposal: 2017-10-31, Version 9.0.0 (Current) Oct 17, 2017

MylesBorins reviewed Oct 23, 2017

View reviewed changes

jasnell changed the base branch from master to v9.x October 28, 2017 22:44

jasnell added this to the 9.0.0 milestone Oct 29, 2017

jasnell force-pushed the v9.0.0-proposal branch from 6891ac2 to 7165af5 Compare October 29, 2017 17:50

jasnell force-pushed the v9.0.0-proposal branch 4 times, most recently from 3383a94 to fcee247 Compare October 30, 2017 07:13

jasnell removed the wip Issues and PRs that are still a work in progress. label Oct 30, 2017

mcollina approved these changes Oct 30, 2017

View reviewed changes

cjihrig approved these changes Oct 30, 2017

View reviewed changes

evanlucas approved these changes Oct 30, 2017

View reviewed changes

jasnell force-pushed the v9.0.0-proposal branch from fcee247 to aeaddc5 Compare October 30, 2017 14:37

fengmk2 reviewed Oct 30, 2017

View reviewed changes

rvagg mentioned this pull request Oct 30, 2017

Support both OpenSSL 1.1.0 and 1.0.2 #16130

Closed

3 tasks

jasnell force-pushed the v9.0.0-proposal branch from aeaddc5 to 285d24f Compare October 31, 2017 14:24

jasnell force-pushed the v9.0.0-proposal branch from 285d24f to 80cd3e1 Compare October 31, 2017 16:44

jasnell force-pushed the v9.0.0-proposal branch from 80cd3e1 to fa9990f Compare October 31, 2017 18:53

Working on v9.0.1

fbde292

PR-URL: #15135

jasnell merged commit fbde292 into v9.x Oct 31, 2017

jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 31, 2017

Blog: v9.0.0 release post

58a500f

Refs: nodejs/node#15135

jasnell mentioned this pull request Oct 31, 2017

Blog: v9.0.0 release post nodejs/nodejs.org#1437

Merged

jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 31, 2017

Blog: v9.0.0 release post (#1437 )

dbe685b

Refs: nodejs/node#15135

rvagg deleted the v9.0.0-proposal branch October 31, 2017 22:53

cjihrig mentioned this pull request Nov 7, 2017

v9.1.0 proposal #16851

Merged

               <a href="doc/changelogs/CHANGELOG_V8.md#8.0.0">8.0.0</a><br/>
                   </td>
-                  <td valign="top">
-              <b><a href="doc/changelogs/CHANGELOG_V7.md#7.10.1">7.10.1</a></b><br/>

+              * [[`2249234fee`](https://github.com/nodejs/node/commit/2249234fee)] - **(SEMVER-MAJOR)** **fs**: invoke callbacks with undefined context (Rich Trott) [#14645](https://github.com/nodejs/node/pull/14645)
+              * [[`f2f391e575`](https://github.com/nodejs/node/commit/f2f391e575)] - **(SEMVER-MAJOR)** **http**: send 400 bad request on parse error (mog422) [#15324](https://github.com/nodejs/node/pull/15324)
+              * [[`10be20a0e8`](https://github.com/nodejs/node/commit/10be20a0e8)] - **(SEMVER-MAJOR)** **http**: set socket timeout when socket connects (Luigi Pinca) [#8895](https://github.com/nodejs/node/pull/8895)
+              * [[`620ba41694`](https://github.com/nodejs/node/commit/620ba41694)] - **(SEMVER-MAJOR)** **http**: don't double-fire the req error event (fengmk2) [#14659](https://github.com/nodejs/node/pull/14659)

Proposal: 2017-10-31, Version 9.0.0 (Current) by jasnell · Pull Request #15135 · nodejs/node · GitHub

Uh oh!

Uh oh!

Proposal: 2017-10-31, Version 9.0.0 (Current) - #15135

Proposal: 2017-10-31, Version 9.0.0 (Current)#15135jasnell merged 2 commits intov9.xnodejs/node:v9.xfrom v9.0.0-proposalnodejs/node:v9.0.0-proposalCopy head branch name to clipboard

Conversation

jasnell commented Sep 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver-Major

Semver-minor

Semver-patch

Uh oh!

MylesBorins commented Sep 10, 2017

Uh oh!

jasnell commented Oct 17, 2017

Uh oh!

MylesBorins Oct 23, 2017

Choose a reason for hiding this comment

Uh oh!

jasnell Oct 23, 2017

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Oct 24, 2017

Uh oh!

jasnell commented Oct 24, 2017

Uh oh!

jasnell commented Oct 28, 2017

Uh oh!

mcollina commented Oct 29, 2017

Uh oh!

apapirovski commented Oct 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Oct 29, 2017

Uh oh!

jasnell commented Oct 30, 2017

Uh oh!

AndreasMadsen commented Oct 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Oct 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengmk2 Oct 30, 2017

Choose a reason for hiding this comment

Uh oh!

rvagg commented Oct 30, 2017

Uh oh!

MylesBorins commented Oct 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Oct 31, 2017

Uh oh!

MylesBorins commented Oct 31, 2017

Uh oh!

cjihrig commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

addaleax commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017 via email

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

tniessen commented Oct 31, 2017

Uh oh!

rvagg commented Oct 31, 2017

Proposal: 2017-10-31, Version 9.0.0 (Current)#15135
jasnell merged 2 commits into
v9.xfrom
v9.0.0-proposal

jasnell commented Sep 1, 2017 •
edited
Loading

apapirovski commented Oct 29, 2017 •
edited
Loading

AndreasMadsen commented Oct 30, 2017 •
edited
Loading

jasnell commented Oct 30, 2017 •
edited
Loading

MylesBorins commented Oct 31, 2017 •
edited
Loading

jasnell commented Oct 31, 2017 •
edited
Loading