FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace concatenation with template literals. by xeodou · Pull Request #14281 · nodejs/node · GitHub

/ node Public

test: replace concatenation with template literals. - #14281

Closed
xeodou wants to merge 1 commit into
nodejs:masterfrom
xeodou:test-path-parse-format
ConversationCommits (1)ChecksFiles changed
Closed

test: replace concatenation with template literals.#14281
xeodou wants to merge 1 commit into
nodejs:masterfrom
xeodou:test-path-parse-format

Conversation

xeodou commented Jul 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
Trott requested changes Jul 16, 2017
View reviewed changes
Comment thread test/parallel/test-path-parse-format.js Outdated

Trott Jul 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does this get flagged as too long when you run make jslint (or vcbuild jslint on Windows)?

If so, maybe it can be split onto two lines?:

message: 'The "pathObject" argument must be of type Object. ' +
  `Received type ${typeName(pathObject)}`;

It only gets rid of one of the concatenations rather than both that way, but I'm not sure there's a good way around it with the line length limit.

xeodou force-pushed the test-path-parse-format branch from 0bee10a to 4c61fdb Compare July 16, 2017 07:54

xeodou commented Jul 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/ping @Trott The change is fixed.

Trott approved these changes Jul 16, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green!

vsemozhetbyt commented Jul 16, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9169/

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

CI was green but I canceled some of the slower hosts to help with our CI jobs backlog. IMO this can be considered green CI.

gireeshpunathil approved these changes Jul 17, 2017
View reviewed changes

gireeshpunathil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would have been good to improve the cohesion and clarity by joining the two sentences with a preposition such as but or instead

tniessen commented Jul 17, 2017

Copy link
Copy Markdown
Member

@gireeshpunathil Even though I agree, that is out of the scope of this PR. These error messages are generated automatically by internal/errors.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 24, 2017
test: replace concatenation with template literals
3566195 
PR-URL: nodejs#14281
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Jul 24, 2017

Copy link
Copy Markdown
Member

Landed in 3566195

Thanks for the contribution! 🎉

Trott closed this Jul 24, 2017
jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL