FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: finish migrating to internal/errors by jasnell · Pull Request #16540 · nodejs/node · GitHub

/ node Public

zlib: finish migrating to internal/errors - #16540

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:migrate-zlib-internal-errors
ConversationCommits (1)ChecksFiles changed
Closed

zlib: finish migrating to internal/errors#16540
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:migrate-zlib-internal-errors

Conversation

jasnell commented Oct 27, 2017

Copy link
Copy Markdown
Member

Finish migrating the zlib binding over to use internal/errors

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib, errors

jasnell added errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. zlib Issues and PRs related to the zlib subsystem. labels Oct 27, 2017
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. zlib Issues and PRs related to the zlib subsystem. labels Oct 27, 2017

jasnell commented Oct 27, 2017

Copy link
Copy Markdown
Member Author

ping @nodejs/tsc

refack approved these changes Oct 27, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FWIW

joyeecheung approved these changes Oct 27, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a question?

Comment thread src/node_zlib.cc Outdated

joyeecheung Oct 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any reason we need a goto here? (other than one less line of duplicate code?)

jasnell Oct 27, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

just that... didn't want to duplicate the line of code

joyeecheung commented Oct 27, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11011/

mcollina approved these changes Oct 27, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca reviewed Oct 27, 2017
View reviewed changes
Comment thread test/parallel/test-zlib-failed-init.js Outdated

lpinca Oct 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need a new way to test this error once #16511 is merged.

jasnell force-pushed the migrate-zlib-internal-errors branch from 0257a1d to c8ef9c3 Compare October 29, 2017 17:15
jasnell added a commit that referenced this pull request Oct 29, 2017
zlib: finish migrating to internal/errors
896eaf6 
PR-URL: #16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Oct 29, 2017

Copy link
Copy Markdown
Member Author

Landed in 896eaf6

jasnell closed this Oct 29, 2017
jasnell mentioned this pull request Oct 30, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
zlib: finish migrating to internal/errors
72792fb 
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
zlib: finish migrating to internal/errors
69bcc09 
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
zlib: finish migrating to internal/errors
2bbf7a3 
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
mcollina mcollina approved these changes
joyeecheung joyeecheung approved these changes
+2 more reviewers
refack refack approved these changes
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL