module: fixes #16476 ensuring extension lookups for top main - #16526
Closed
guybedford wants to merge 1 commit into
Closed
module: fixes #16476 ensuring extension lookups for top main#16526guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MylesBorins
approved these changes
Oct 26, 2017
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
addaleax
reviewed
Oct 26, 2017
Comment thread
test/parallel/test-module-main-extensions.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should this ever throw an exception?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
The resolver can throw but it shouldn't... let me clean this up.
Sorry, something went wrong.
Comment thread
test/parallel/test-module-main-extensions.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This line isn’t going to do anything, right? Am I missing something?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is just from a habit of ensuring there is at least one assertion in a test. Can remove.
Sorry, something went wrong.
targos
approved these changes
Oct 26, 2017
cjihrig
approved these changes
Oct 26, 2017
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM once the test nits are addressed.
Sorry, something went wrong.
guybedford
force-pushed
the
esm-main-extensions
branch
from
07e09ca to
335d4e1
Compare
October 26, 2017 20:14
Copy link
Copy Markdown
Contributor
Author
|
Tests updated, and tested on Windows too. Should be good for CI. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
What about naming the file test-module-main-no-extension.js to better explain what it's testing? |
Sorry, something went wrong.
guybedford
force-pushed
the
esm-main-extensions
branch
from
335d4e1 to
eb02e5e
Compare
October 26, 2017 20:22
guybedford
force-pushed
the
esm-main-extensions
branch
from
eb02e5e to
5d040c2
Compare
October 26, 2017 20:29
benjamingr
approved these changes
Oct 26, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 28, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: #16526 Fixes: #16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: #16526 Fixes: #16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: #16526 Fixes: #16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: #16526 Fixes: #16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: nodejs/node#16526 Fixes: nodejs/node#16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: nodejs/node#16526 Fixes: nodejs/node#16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Copy link
Copy Markdown
Contributor
|
Assuming this shouldn't land on v6.x Please lmk if I'm mistken |
Sorry, something went wrong.
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
The reason is that absolute URLs do not go through extension and index checks. By switching to an absolute path, the resolver still applies extensions properly to the top-level main. PR-URL: nodejs/node#16526 Fixes: nodejs/node#16476 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason as stated in #16476 (comment) is that absolute URLs do not go through extension and index checks.
By switching to an absolute path, the resolver still applies extensions properly to the top-level main.
Checklist
Affected core subsystem(s)
esmodules