build: stop support building addons with VS 2013 - #14764
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bnoordhuis
approved these changes
Aug 11, 2017
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
\o/
Sorry, something went wrong.
tniessen
approved these changes
Aug 11, 2017
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Change itself LGTM
Sorry, something went wrong.
refack
approved these changes
Aug 11, 2017
refack
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Reminder: Don't land in 8
Sorry, something went wrong.
Copy link
Copy Markdown
Member
They should be redundant, but adding the labels anyway. |
Sorry, something went wrong.
gibfahn
approved these changes
Aug 11, 2017
Trott
approved these changes
Aug 11, 2017
lpinca
approved these changes
Aug 12, 2017
targos
added a commit
to targos/node
that referenced
this pull request
Aug 18, 2017
PR-URL: nodejs#14764 Refs: nodejs#14730 (comment) Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we won't have to float a patch in future V8 upgrades.
Ref: #14730 (comment)
/cc @nodejs/platform-windows @nodejs/ctc
Checklist