FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix typos by BridgeAR · Pull Request #13741 · nodejs/node · GitHub

/ node Public

lib: fix typos - #13741

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix-typos
ConversationCommits (2)ChecksFiles changed
Closed

lib: fix typos#13741
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix-typos

Conversation

BridgeAR commented Jun 17, 2017

Copy link
Copy Markdown
Member

Just some small typos.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 17, 2017
mscdex reviewed Jun 17, 2017
View reviewed changes
Comment thread lib/internal/socket_list.js Outdated

mscdex Jun 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/send/sent/ ?

silverwind commented Jun 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think some of these were fixed in ecf6a46 which just landed, you should rebase.

mscdex reviewed Jun 18, 2017
View reviewed changes
Comment thread lib/internal/socket_list.js Outdated
const EventEmitter = require('events');

// This object keep track of the socket there are sended
// This object keeps track of the socket that is sent

mscdex Jun 18, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not 100% sure, but I think it should be 'sockets' instead of 'socket' and then s/is/are/

Also, the SocketListReceive description below needs to be updated similarly as well.

cjihrig approved these changes Jun 19, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM once @mscdex's comment is addressed.

silverwind commented Jun 19, 2017

Copy link
Copy Markdown
Contributor

Thanks! Landed in c474f88.

silverwind closed this Jun 19, 2017
silverwind pushed a commit that referenced this pull request Jun 19, 2017
lib: fix typos
c474f88 
PR-URL: #13741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
refack reviewed Jun 20, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(fondly reminded of inspector Enbale)

addaleax commented Jun 29, 2017

Copy link
Copy Markdown
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

BridgeAR commented Jul 2, 2017

Copy link
Copy Markdown
Member Author

I'll open a backport some time later tonight.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jul 2, 2017
lib: fix typos
e02be07 
PR-URL: nodejs#13741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
BridgeAR mentioned this pull request Jul 2, 2017
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Jul 3, 2017
lib: fix typos
95ab616 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
lib: fix typos
8a467ae 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
lib: fix typos
4bb1a3a 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
lib: fix typos
d133e33 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
lib: fix typos
600d009 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
lib: fix typos
81edf59 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
BridgeAR deleted the fix-typos branch April 1, 2019 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+4 more reviewers
mscdex mscdex left review comments
refack refack left review comments
silverwind silverwind approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL