FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] lib: fix typos by BridgeAR · Pull Request #14044 · nodejs/node · GitHub

/ node Public

[v8.x backport] lib: fix typos - #14044

Closed
BridgeAR wants to merge 1 commit into
nodejs:v8.x-stagingfrom
BridgeAR:backport-13741-to-8.x
Closed

[v8.x backport] lib: fix typos#14044
BridgeAR wants to merge 1 commit into
nodejs:v8.x-stagingfrom
BridgeAR:backport-13741-to-8.x

Conversation

BridgeAR commented Jul 2, 2017

Copy link
Copy Markdown
Member

Backport #13741 to 8.x

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

PR-URL: nodejs#13741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jul 2, 2017

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tniessen changed the title lib: fix typos [v6.x backport] lib: fix typos Jul 3, 2017
tniessen changed the title [v6.x backport] lib: fix typos [v8.x backport] lib: fix typos Jul 3, 2017

addaleax commented Jul 3, 2017

Copy link
Copy Markdown
Member

addaleax pushed a commit that referenced this pull request Jul 3, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax commented Jul 3, 2017

Copy link
Copy Markdown
Member

Landed in v8.x-staging @ 95ab616

addaleax closed this Jul 3, 2017
addaleax mentioned this pull request Jul 3, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Roman Reiss <me@silverwind.io>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #14044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Aug 16, 2017
BridgeAR deleted the backport-13741-to-8.x branch April 1, 2019 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL