FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

process: use internal/errors in internalNextTick by tniessen · Pull Request #13982 · nodejs/node · GitHub

/ node Public

process: use internal/errors in internalNextTick - #13982

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:next-tick-internal-error
ConversationCommits (1)ChecksFiles changed
Closed

process: use internal/errors in internalNextTick#13982
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:next-tick-internal-error

Conversation

tniessen commented Jun 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #12892
Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jun 29, 2017
tniessen added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 29, 2017
jasnell mentioned this pull request Jun 30, 2017
Closed
80 tasks
tniessen self-assigned this Jun 30, 2017

tniessen commented Jul 2, 2017

Copy link
Copy Markdown
Member Author

Landed in 3129b2c

tniessen closed this Jul 2, 2017
tniessen added a commit that referenced this pull request Jul 2, 2017
process: use internal/errors in internalNextTick
3129b2c 
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
process: use internal/errors in internalNextTick
858c14e 
PR-URL: nodejs#13982
Refs: nodejs#12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax mentioned this pull request Jul 3, 2017
Merged

mhdawson commented Jul 6, 2017

Copy link
Copy Markdown
Member

@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect.

mhdawson added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 6, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
process: use internal/errors in internalNextTick
3a65c09 
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
process: use internal/errors in internalNextTick
539f4c0 
PR-URL: #13982
Refs: #12892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

tniessen

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL