src: fix vm module for strict mode - #16487
Closed
fhinkel wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This fixes the issue, but it's not pretty. Not sure if we want to fix the issue like this or completely rethink our strategy for throwing in the sandboxed environment. |
Sorry, something went wrong.
bnoordhuis
approved these changes
Oct 25, 2017
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Doesn't seem too terrible to me although there might be a bit of a performance hit (two lookups instead of sometimes one, sometimes two - although I expect the latter is the more common path.)
Sorry, something went wrong.
Comment thread
src/node_contextify.cc
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
is_declared_on_global_proxy?
Sorry, something went wrong.
targos
approved these changes
Oct 25, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. Fixes: nodejs#12300
jasnell
approved these changes
Oct 25, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
(somewhat rubber-stampy lgtm)
Sorry, something went wrong.
addaleax
approved these changes
Oct 25, 2017
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the reviews. Landed in 5856c83 |
Sorry, something went wrong.
fhinkel
added a commit
that referenced
this pull request
Oct 27, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: #16487 Fixes: #12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: #16487 Fixes: #12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: #16487 Fixes: #12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: #16487 Fixes: #12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: nodejs/node#16487 Fixes: nodejs/node#12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: nodejs/node#16487 Fixes: nodejs/node#12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Contributor
|
Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: nodejs/node#16487 Fixes: nodejs/node#12300 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem with variables that
are declared only on the sandbox but not on the
global proxy.
Fixes: #12300
Checklist
Affected core subsystem(s)
src