FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: use destructuring for constants on the top-level module scope by starkwang · Pull Request #16063 · nodejs/node · GitHub

/ node Public

lib: use destructuring for constants on the top-level module scope - #16063

Closed
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:use-destruct-for-constants
ConversationCommits (1)ChecksFiles changed
Closed

lib: use destructuring for constants on the top-level module scope#16063
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:use-destruct-for-constants

Conversation

starkwang commented Oct 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change is to unify the declaration for constants into using destructuring on the top-level-module scope, reducing some redundant code.

By the way, what about adding "prefer-destructuring" into the .eslintrc ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 7, 2017
addaleax approved these changes Oct 7, 2017
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but be prepared to rebase if it becomes necessary :)

BridgeAR commented Oct 9, 2017

Copy link
Copy Markdown
Member

The commit message exceeds the 50 character maximum though. It would be nice if this could be fixed before landing.

starkwang force-pushed the use-destruct-for-constants branch from 993bbee to 49f469e Compare October 9, 2017 09:46

starkwang commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

@BridgeAR I've just shortened the commit message : )

gibfahn commented Oct 9, 2017

Copy link
Copy Markdown
Member

By the way, what about adding "prefer-destructuring" into the .eslintrc ?

Seems reasonable to me.

TimothyGu reviewed Oct 10, 2017
View reviewed changes
Comment thread lib/_http_client.js Outdated

TimothyGu Oct 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suppose you can add _checkIsHttpToken: checkIsHttpToken too here, which would get rid of the only reference to common in the file other than this one. Also would you mind sorting these in alphabetical order?

Comment thread lib/_http_server.js Outdated

TimothyGu Oct 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ditto, but with _checkInvalidHeaderChar instead.

Comment thread lib/child_process.js Outdated

TimothyGu Oct 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This can be refactored as well.

starkwang force-pushed the use-destruct-for-constants branch from 49f469e to 6c53ee8 Compare October 11, 2017 04:54

starkwang commented Oct 11, 2017

Copy link
Copy Markdown
Contributor Author

Pushed commit to address comments.

lib: use destructuring for some constants
4fa9357 
This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.
starkwang force-pushed the use-destruct-for-constants branch from 6c53ee8 to 4fa9357 Compare October 11, 2017 04:58

tniessen commented Oct 16, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10765/

tniessen self-assigned this Oct 16, 2017

tniessen commented Oct 16, 2017

Copy link
Copy Markdown
Member

Landed in 212de3c, thanks! 😃

tniessen closed this Oct 16, 2017
tniessen pushed a commit that referenced this pull request Oct 16, 2017
lib: use destructuring for some constants
212de3c 
This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: #16063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
lib: use destructuring for some constants
49a6520 
This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: nodejs/node#16063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Does this change offer any performance improvements? These kind of large changes are going to create backporting conflicts that will be hard to manage for LTS

With that being said this does not land cleanly on 8.x. Would someone be willing to manually backport

lance mentioned this pull request Oct 25, 2017
Closed
2 tasks

lance commented Oct 25, 2017

Copy link
Copy Markdown
Member

@MylesBorins just submitted backport PR: #16494. The main conflicts that arose had to do with the semver-major commits around internal/errors like this one. Just FYI.

jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
lib: use destructuring for some constants
1909430 
This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: #16063
Backport-PR-URL: #16494
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
lib: use destructuring for some constants
96e8250 
This change is to unify the declaration for constants into using
destructuring on the top-level-module scope, reducing some redundant
code.

PR-URL: #16063
Backport-PR-URL: #16494
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged

MylesBorins commented Nov 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not landing this on v6.x

But want to once again urge collaborators that would should consider holding off on larger changes like this until v6.x goes into maintenance, this has the potential to cause a bunch of conflicts

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
tniessen tniessen approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
TimothyGu TimothyGu left review comments
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tniessen

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL