FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: migrate crypto sign to internal/errors by jasnell · Pull Request #15757 · nodejs/node · GitHub

/ node Public

crypto: migrate crypto sign to internal/errors - #15757

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:crypto-sign-internal-errors
ConversationCommits (2)ChecksFiles changed
Closed

crypto: migrate crypto sign to internal/errors#15757
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:crypto-sign-internal-errors

Conversation

jasnell commented Oct 3, 2017

Copy link
Copy Markdown
Member

Improve argument type checking and move into js, use internal/errors

Improve tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

jasnell added errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. labels Oct 3, 2017
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 3, 2017
lpinca approved these changes Oct 5, 2017
View reviewed changes
Comment thread lib/internal/crypto/sig.js Outdated

lpinca Oct 5, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: toBuf() seems redundant here.

Comment thread lib/internal/crypto/sig.js Outdated

lpinca Oct 5, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: maybe it's better to move this after the instanceof check to only run it once when Sign is called without new.

Comment thread lib/internal/crypto/sig.js Outdated

lpinca Oct 5, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ditto.

jasnell commented Oct 13, 2017

Copy link
Copy Markdown
Member Author

@nodejs/tsc ... ping? Please review?

jasnell requested a review from a team October 13, 2017 21:22
joyeecheung reviewed Oct 14, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Next step would be to migrate SignBase::CheckThrow...

joyeecheung approved these changes Oct 14, 2017
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Checked the wrong box before

joyeecheung commented Oct 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Also after this patch, sign.sign() and verify.verify() take array buffer views as key, the documentation need to be updated (not necessarily in this PR)

jasnell commented Oct 16, 2017

Copy link
Copy Markdown
Member Author

re: SignBase::CheckThrow and the doc updates... yes, I intend to do both in separate PRs.

jasnell force-pushed the crypto-sign-internal-errors branch from f143a84 to 2579276 Compare October 16, 2017 16:59

jasnell commented Oct 16, 2017

Copy link
Copy Markdown
Member Author

@nodejs/tsc ... need at least one more TSC signoff on this please

mcollina approved these changes Oct 16, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson approved these changes Oct 16, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Oct 16, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10764/

crypto: migrate crypto sign to internal/errors
94eaae6 
Improve argument type checking and move into js, use internal/errors
[Squash] Remove now unnecessary error checks
cee5974
jasnell force-pushed the crypto-sign-internal-errors branch from 2579276 to cee5974 Compare October 20, 2017 21:34

jasnell commented Oct 20, 2017

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/10878/

jasnell commented Oct 23, 2017

Copy link
Copy Markdown
Member Author

CI was a bit too red, trying again: https://ci.nodejs.org/job/node-test-commit/13401/

jasnell added a commit that referenced this pull request Oct 24, 2017
crypto: migrate crypto sign to internal/errors
b8bc652 
Improve argument type checking and move into js, use internal/errors

PR-URL: #15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell commented Oct 24, 2017

Copy link
Copy Markdown
Member Author

Landed in b8bc652

jasnell closed this Oct 24, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
crypto: migrate crypto sign to internal/errors
3fcb6c4 
Improve argument type checking and move into js, use internal/errors

PR-URL: nodejs/node#15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
crypto: migrate crypto sign to internal/errors
1b0e1c4 
Improve argument type checking and move into js, use internal/errors

PR-URL: nodejs/node#15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL