FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: modernize tools/license2rtf.js by tniessen · Pull Request #16220 · nodejs/node · GitHub

/ node Public

tools: modernize tools/license2rtf.js - #16220

Closed
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:tools-license-es6
ConversationCommits (3)ChecksFiles changed
Closed

tools: modernize tools/license2rtf.js#16220
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:tools-license-es6

Conversation

tniessen commented Oct 15, 2017

Copy link
Copy Markdown
Member

This PR tries to modernize some tooling code. Should still produce the same result:

$ git checkout master
Switched to branch 'master'
$ Release/node tools/license2rtf.js > LICENSE_ORIGINAL.rtf
$ cat LICENSE | Release/node tools/license2rtf.js > LICENSE_ORIGINAL.rtf
$ git checkout tools-license-es6
Switched to branch 'tools-license-es6'
$ cat LICENSE | Release/node tools/license2rtf.js > LICENSE_NEW.rtf
$ sha256sum LICENSE_ORIGINAL.rtf LICENSE_NEW.rtf
4331ecea25a7cfc6948d7fdd8b3e298f54de913591e6a3962b8302b80179acbb *LICENSE_ORIGINAL.rtf
4331ecea25a7cfc6948d7fdd8b3e298f54de913591e6a3962b8302b80179acbb *LICENSE_NEW.rtf

Changes:

  • ES classes instead of util.inherits
  • ES string functions (trimRight, padStart)
  • Template strings

There are still some possible improvements but it's a start.

Checklist
Affected core subsystem(s)

tools

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 15, 2017
tniessen self-assigned this Oct 15, 2017
TimothyGu reviewed Oct 15, 2017
View reviewed changes
Comment thread tools/license2rtf.js

Stream.call(this);
this.writable = true;
class LineSplitter extends Stream {

TimothyGu Oct 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not inherit from Stream.Writable which provides automatic backpressure?

tniessen Oct 15, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point, I mostly just rewrote the classes without changing any semantics / inheritance.

lpinca approved these changes Oct 16, 2017
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

SGTM.

Comment thread tools/license2rtf.js Outdated

function rtfEscape(string) {
rtfEscape(string) {
function toHex(number, length) {

lpinca Oct 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: I would move this to the top scope.

targos commented Oct 28, 2017

Copy link
Copy Markdown
Member

ping @tniessen

tniessen commented Oct 28, 2017

Copy link
Copy Markdown
Member Author

I would like to land this without addressing #16220 (comment) which can be done in a separate PR (unless someone objects).

tniessen commented Oct 29, 2017

Copy link
Copy Markdown
Member Author

Landed in 9d76850, e2ce130.

tniessen closed this Oct 29, 2017
tniessen added a commit that referenced this pull request Oct 29, 2017
tools: replace loop with padStart
9d76850 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
tniessen added a commit that referenced this pull request Oct 29, 2017
tools: modernize license2rtf
e2ce130 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
tools: replace loop with padStart
8c1332c 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
tools: modernize license2rtf
d079a81 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
tools: replace loop with padStart
e402694 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
tools: modernize license2rtf
473377f 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
tools: replace loop with padStart
d5891b5 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
tools: modernize license2rtf
3d8a7e9 
PR-URL: #16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
tools: replace loop with padStart
5bc6daf 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
tools: modernize license2rtf
07fa7b7 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
tools: replace loop with padStart
8d1fa06 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
tools: modernize license2rtf
d1dbd95 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
tools: replace loop with padStart
f47c5d0 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
tools: modernize license2rtf
edd9d35 
PR-URL: nodejs/node#16220
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
+2 more reviewers
TimothyGu TimothyGu left review comments
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tniessen

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL