FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors,repl: migrate to use internal/errors.js by sreepurnajasti · Pull Request #13299 · nodejs/node · GitHub

/ node Public

errors,repl: migrate to use internal/errors.js - #13299

Closed
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:repl
ConversationCommits (1)ChecksFiles changed
Closed

errors,repl: migrate to use internal/errors.js#13299
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:repl

Conversation

sreepurnajasti commented May 30, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/internal/repl.js
lib/internal/errors.js

ref: #11273

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. repl Issues and PRs related to the REPL subsystem. labels May 30, 2017
jasnell reviewed May 30, 2017
View reviewed changes
Comment thread lib/internal/errors.js Outdated

jasnell May 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a nit, but it's a bit odd to have one of the new codes use %s while the other uses a template string.

sreepurnajasti May 31, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jasnell I have used template string. So, do you want me to convert it to %s?

jasnell May 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would switch the ERR_INVALID_REPL_HISTORY one to use a template string

sreepurnajasti Jun 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jasnell Done.

jasnell reviewed May 30, 2017
View reviewed changes
Comment thread lib/internal/repl.js Outdated

jasnell May 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should likely be a TypeError. Since this is already a semver-major change, may as well fix the type

sreepurnajasti May 31, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jasnell I too thought on those lines. But to be consistent with previous code, I did in that manner. Now, it is fixed. Thanks.

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 30, 2017
jasnell reviewed May 31, 2017
View reviewed changes
Comment thread lib/internal/repl.js Outdated

jasnell May 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

be sure to line up the arguments appropriate and run make lint

sreepurnajasti Jun 1, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jasnell Unfortunately, it is not captured in lint test. Now, it's Done.

mhdawson approved these changes Jun 1, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Jun 1, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8421/

jasnell pushed a commit that referenced this pull request Jun 2, 2017
errors,repl: migrate to use internal/errors.js
2822796 
PR-URL: #13299
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jun 2, 2017

Copy link
Copy Markdown
Member

Landed in 2822796

jasnell closed this Jun 2, 2017
joyeecheung mentioned this pull request Jun 2, 2017
Closed
4 tasks

tniessen commented Jun 18, 2017

Copy link
Copy Markdown
Member

Too late, but doesn't LGTM. ERR_INVALID_REPL_HISTORY doesn't appear to be used at all. Please review #13733.

tniessen mentioned this pull request Jun 18, 2017
Closed
3 tasks
jasnell mentioned this pull request Oct 30, 2017
Merged
sreepurnajasti deleted the repl branch December 27, 2017 06:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. repl Issues and PRs related to the REPL subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL