FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update V8 to 5.9.211.37 by targos · Pull Request #13631 · nodejs/node · GitHub

/ node Public

deps: update V8 to 5.9.211.37 - #13631

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-v8-59
ConversationCommits (1)ChecksFiles changed
Closed

deps: update V8 to 5.9.211.37#13631
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-v8-59

Conversation

targos commented Jun 12, 2017

Copy link
Copy Markdown
Member

Update to current 5.9-lkgr

@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 12, 2017
targos mentioned this pull request Jun 12, 2017
Closed
2 tasks

targos commented Jun 15, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8674/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/743/

jasnell commented Jun 15, 2017

Copy link
Copy Markdown
Member

Rubber stamp LGTM

rvagg commented Jun 15, 2017

Copy link
Copy Markdown
Member

I missed that 5.9 was merged, but going back through the issues I'm not seeing that we have microbenchmark results for the impact of this upgrade. Has anyone done this?

rvagg commented Jun 15, 2017

Copy link
Copy Markdown
Member

@nodejs/v8 ^^ re benchmarks. I know we have https://benchmarking.nodejs.org/ but has anyone run the benchmarks in source to show the difference?

vsemozhetbyt commented Jun 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@rvagg FWIW, there are rather old results in #11851

rvagg commented Jun 15, 2017

Copy link
Copy Markdown
Member

@vsemozhetbyt that's why I'm interested now, because those results are not promising in the whole

targos commented Jun 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ping @nodejs/v8

Edit: wait, I will update to patch 37.
Edit 2: updated to 5.9.211.37

targos changed the title deps: update V8 to 5.9.211.35 deps: update V8 to 5.9.211.37 Jun 19, 2017

targos commented Jun 19, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8732/
New arm run: https://ci.nodejs.org/job/node-test-commit-arm/10424/
New windows-fanned run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9883/

targos mentioned this pull request Jun 19, 2017
Closed
2 tasks
rvagg mentioned this pull request Jun 19, 2017
Merged

targos commented Jun 20, 2017

Copy link
Copy Markdown
Member Author

Landed in 8f907b6

targos closed this Jun 20, 2017
targos deleted the update-v8-59 branch June 20, 2017 08:53
targos added a commit that referenced this pull request Jun 20, 2017
deps: update V8 to 5.9.211.37
8f907b6 
PR-URL: #13631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

CITGM on master for good measure: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/881/

jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL