FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x] deps: update V8 to 5.9.211.37 by targos · Pull Request #13790 · nodejs/node · GitHub

/ node Public

[v8.x] deps: update V8 to 5.9.211.37 - #13790

Closed
targos wants to merge 1 commit into
nodejs:v8.x-stagingfrom
targos:update-v8-59-v8
ConversationCommits (1)ChecksFiles changed
Closed

[v8.x] deps: update V8 to 5.9.211.37#13790
targos wants to merge 1 commit into
nodejs:v8.x-stagingfrom
targos:update-v8-59-v8

Conversation

targos commented Jun 19, 2017

Copy link
Copy Markdown
Member

@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Jun 19, 2017

targos commented Jun 19, 2017

Copy link
Copy Markdown
Member Author

V8 diff: v8/v8@5.9.211.35...5.9.211.37

bnoordhuis commented Jun 19, 2017

Copy link
Copy Markdown
Member

Also, how come v8.x is ahead of master? These are strange and unsettling times we live in.

targos commented Jun 19, 2017

Copy link
Copy Markdown
Member Author

I did not really expect my 5.9 PR to be landed on v8.x before #13631. I thought we were waiting for the CITGM checks. Maybe I should have marked it as blocked until then.

addaleax commented Jun 19, 2017

Copy link
Copy Markdown
Member

I did not really expect my 5.9 PR to be landed on v8.x before #13631.

@targos Sorry if this seemed too early, I hadn’t seen #13631 yet.

(Is that PR ready to land? I agree it would be odd to push v8.x further ahead of master by merging this.)

targos commented Jun 20, 2017

Copy link
Copy Markdown
Member Author

I landed #13631 on master today.

CI: https://ci.nodejs.org/job/node-test-pull-request/8759/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/751/

addaleax pushed a commit that referenced this pull request Jun 20, 2017
deps: update V8 to 5.9.211.37
e47fd6d 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax commented Jun 20, 2017

Copy link
Copy Markdown
Member

Landed in e47fd6d @ v8.x-staging, thank you!

addaleax closed this Jun 20, 2017
addaleax mentioned this pull request Jun 21, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
deps: update V8 to 5.9.211.37
e618ae6 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos deleted the update-v8-59-v8 branch June 21, 2017 21:13
addaleax pushed a commit that referenced this pull request Jun 24, 2017
deps: update V8 to 5.9.211.37
a8911c8 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
deps: update V8 to 5.9.211.37
93b8b9d 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
deps: update V8 to 5.9.211.37
dbc6915 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
deps: update V8 to 5.9.211.37
cffe541 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to targos/node that referenced this pull request Jul 21, 2017
deps: update V8 to 5.9.211.37
147d8f1 
PR-URL: nodejs#13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jul 24, 2017
deps: update V8 to 5.9.211.37
da93046 
PR-URL: #13790
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax mentioned this pull request Jul 24, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL