FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

_http_outgoing: migrate to use internal/errors by starkwang · Pull Request #14735 · nodejs/node · GitHub

/ node Public

_http_outgoing: migrate to use internal/errors - #14735

Closed
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:http-outgoing-internal-errors
ConversationCommits (1)ChecksFiles changed
Closed

_http_outgoing: migrate to use internal/errors#14735
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:http-outgoing-internal-errors

Conversation

starkwang commented Aug 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http, errors

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. labels Aug 10, 2017
jasnell approved these changes Aug 10, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with green CI

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 10, 2017
refack self-assigned this Aug 12, 2017
jasnell mentioned this pull request Aug 12, 2017
Closed
80 tasks
refack approved these changes Aug 12, 2017
View reviewed changes
Comment thread test/parallel/test-http-mutable-headers.js Outdated

refack Aug 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@starkwang how much work will it to add the given value (in addition to the token name)?

starkwang Aug 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added some more information about the given value in the error message.

starkwang force-pushed the http-outgoing-internal-errors branch from ae9c960 to 0fcece2 Compare August 13, 2017 15:29
starkwang mentioned this pull request Aug 13, 2017
Closed
3 tasks
refack approved these changes Aug 13, 2017
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💯

refack commented Aug 13, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9643/

refack commented Aug 13, 2017

Copy link
Copy Markdown
Contributor

/cc @mcollina @mhdawson @fhinkel

mhdawson approved these changes Aug 14, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks !

mhdawson commented Aug 14, 2017

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/9660/

refack commented Aug 14, 2017

Copy link
Copy Markdown
Contributor

Landed in 11a2ca2
(had a green CI from 23h ago)

refack closed this Aug 14, 2017
refack pushed a commit that referenced this pull request Aug 14, 2017
errors: migrate _http_outgoing
11a2ca2 
PR-URL: #14735
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
maclover7 mentioned this pull request Nov 24, 2017
Closed
refack removed their assignment Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
refack refack approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL