FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: be more specific when reporting errors by indutny · Pull Request #14759 · nodejs/node · GitHub

/ node Public

http: be more specific when reporting errors - #14759

Closed
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:fix/gh-14754
ConversationCommits (1)ChecksFiles changed
Closed

http: be more specific when reporting errors#14759
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:fix/gh-14754

Conversation

indutny commented Aug 11, 2017

Copy link
Copy Markdown
Member

When reporting header content errors specify header name in the message
for easier debugging in user applications.

Fix: #14754

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

http: be more specific when reporting errors
6f71f83 
When reporting header content errors specify header name in the message
for easier debugging in user applications.

Fix: nodejs#14754
indutny added the http Issues or PRs related to the http subsystem. label Aug 11, 2017
indutny requested review from jasnell and mscdex August 11, 2017 01:59
nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 11, 2017
indutny mentioned this pull request Aug 11, 2017
Closed
mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 11, 2017

mscdex commented Aug 11, 2017

Copy link
Copy Markdown
Contributor

How about more simply: 'The header content contains invalid characters: ' + name ?

indutny commented Aug 11, 2017

Copy link
Copy Markdown
Member Author

@mscdex I don't mind. Although, both are consistent with existing error messages.

jasnell reviewed Aug 11, 2017
View reviewed changes
Comment thread lib/_http_outgoing.js
debug('Header "%s" contains invalid characters', key);
throw new TypeError('The header content contains invalid characters');
throw new TypeError(
'The header content contains invalid characters ["' + key + '"]');

jasnell Aug 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If the error messages are being changed, it would be nice to migrate the files to use internal/errors at the same time.

jasnell approved these changes Aug 11, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Specific change LGTM with a suggestion

starkwang commented Aug 13, 2017

Copy link
Copy Markdown
Contributor

The errors in lib/_http_outgoing.js is being migrated to use internal/errors(#14735). I've added the header name in the error message.

jasnell commented Aug 23, 2017

Copy link
Copy Markdown
Member

@indutny ... can you give this a rebase?

indutny commented Aug 23, 2017

Copy link
Copy Markdown
Member Author

@jasnell is it relevant after #14735?

jasnell commented Aug 23, 2017

Copy link
Copy Markdown
Member

It appears your're right :-)

jasnell closed this Aug 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
mscdex Awaiting requested review from mscdex
+1 more reviewer
evanlucas evanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Header name is not added in the error message for the case of invalid characters in the header

8 participants

Back | FazBrowse Home | New Git URL