http2: fix compiler errors in debug statements - #16373
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
jasnell
approved these changes
Oct 22, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Out of curiosity what os are you building on?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jasnell I'm on macOS 10.12.6. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ok. I haven't built on Mac with the --debug-http2 option in quite some time. Thanks for catching that! :) |
Sorry, something went wrong.
apapirovski
added a commit
that referenced
this pull request
Oct 24, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: nodejs/node#16373 Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: nodejs/node#16373 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. I'm not certain if this is something about my system or if I'm missing something here since no one else has noticed... then again maybe I'm the only one using --debug-http2 at this moment.
../src/node_http2.cc:141:17: error: cannot pass object of non-trivial type 'node::AliasedBuffer<unsigned int, v8::Uint32Array>::Reference' through variadic function; call will abort at runtime [-Wnon-pod-varargs] buffer[IDX_SETTINGS_HEADER_TABLE_SIZE]);This fixes the issue by casting to uint32_t.
Checklist
Affected core subsystem(s)
http2