FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: updated error message for messages count by dinophile · Pull Request #15979 · nodejs/node · GitHub

/ node Public

test: updated error message for messages count - #15979

Closed
dinophile wants to merge 5 commits into
nodejs:masterfrom
dinophile:carrowsmith/test-dgram-multicast-multi-process.js
ConversationCommits (5)ChecksFiles changed
Closed

test: updated error message for messages count#15979
dinophile wants to merge 5 commits into
nodejs:masterfrom
dinophile:carrowsmith/test-dgram-multicast-multi-process.js

Conversation

dinophile commented Oct 6, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 6, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
cjihrig reviewed Oct 7, 2017
View reviewed changes
Comment thread test/internet/test-dgram-multicast-multi-process.js Outdated
assert.strictEqual(count, messages.length,
'A worker received an invalid multicast message');
`A worker received an invalid multicast message:
Recieved ${messages.length}, should be ${count}`);

cjihrig Oct 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Recieved -> Received

BridgeAR Oct 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Using multiline template strings is actually discouraged. This would add lots of extra whitespace to the error message. Please use this instead

'A worker received an invalid multicast message' +
  `Received ${messages.length}, should be ${count}`

dinophile Oct 8, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! I didn't know about that, we do try to keep messages very short in our code base at work so I didn't know how to handle longer strings! Will fix!

dinophile commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

Oh dear...I get caught by that 'i before e' rule when typing all the time! Thank you for the catch!

jasnell previously approved these changes Oct 10, 2017
View reviewed changes
lpinca reviewed Oct 13, 2017
View reviewed changes
Comment thread test/internet/test-dgram-multicast-multi-process.js Outdated
assert.strictEqual(count, messages.length,
'A worker received an invalid multicast message');
'A worker received an invalid multicast message' +
`Received ${messages.length}, should be ${count}`);

lpinca Oct 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If I'm not wrong it should be the opposite: Received ${count}, should be ${messages.length}.
I also think it makes sense to remove the error message in favor of the default one.

dinophile Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I thought count is the expected number and messages.length is the actual number recieved? I'm actually away from my computer until the 23rd (on vacation!) So I can't take a look until then! But I agree taking out the error message would be a good idea!

BridgeAR Oct 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, it is actually the other way around.

lpinca Oct 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Even if reversed the message is still misleading as the assertion is actually run when all messages are received by all workers, so my suggestion is to get rid of the message argument completely and use the default error message.

assert.strictEqual(count, messages.length);

lpinca Oct 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See #15998 (comment). It's the same here.

jasnell dismissed their stale review October 18, 2017 18:04

@lpinca is correct.

Trott commented Oct 27, 2017

Copy link
Copy Markdown
Member

I went and fixed the nit from @lpinca. I think this is ready to go. PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/11010/

joyeecheung commented Oct 27, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11017/

tniessen commented Oct 28, 2017

Copy link
Copy Markdown
Member

Landed in 65b8d21, thank you! 🎉

tniessen closed this Oct 28, 2017
tniessen pushed a commit that referenced this pull request Oct 28, 2017
test: show values instead of assertion message
65b8d21 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: show values instead of assertion message
b061a5a 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: show values instead of assertion message
ef3db41 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
test: show values instead of assertion message
604ab12 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: show values instead of assertion message
364b07e 
PR-URL: nodejs/node#15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: show values instead of assertion message
20634fc 
PR-URL: nodejs/node#15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: show values instead of assertion message
68f70d7 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: show values instead of assertion message
fcd0c91 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: show values instead of assertion message
91f9779 
PR-URL: #15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
test: show values instead of assertion message
fa59c37 
PR-URL: nodejs/node#15979
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig left review comments
BridgeAR BridgeAR left review comments
lpinca lpinca approved these changes
gireeshpunathil gireeshpunathil approved these changes
jasnell jasnell left review comments

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL