FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improved assert message on cluster-worker-disconnect by Hadis-Fard · Pull Request #16021 · nodejs/node · GitHub

/ node Public

improved assert message on cluster-worker-disconnect - #16021

Closed
Hadis-Fard wants to merge 3 commits into
nodejs:masterfrom
Hadis-Fard:master
ConversationCommits (3)ChecksFiles changed
Closed

improved assert message on cluster-worker-disconnect#16021
Hadis-Fard wants to merge 3 commits into
nodejs:masterfrom
Hadis-Fard:master

Conversation

Hadis-Fard commented Oct 6, 2017

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
mscdex added the cluster Issues and PRs related to the cluster subsystem. label Oct 6, 2017
BridgeAR reviewed Oct 6, 2017
View reviewed changes
Comment thread test/parallel/test-cluster-worker-disconnect.js Outdated
'The state property was not set, current state is ${w.state}');
assert.strictEqual(w.voluntaryMode, true,
'Voluntary exit mode was not set');
'Voluntary exit mode was not set, current voluntary mode is ${w.voluntaryMode}');

BridgeAR Oct 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The line length is to long. It would actually be best to just remove the message overall. The message from strictEqual should be better than the current situation. The same applies to w.state.

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017

gireeshpunathil commented Oct 22, 2017

Copy link
Copy Markdown
Member

ping @Hadis-Fard

jasnell reviewed Oct 23, 2017
View reviewed changes
Comment thread test/parallel/test-cluster-worker-disconnect.js Outdated
worker.once('listening', common.mustCall(() => {
const w = worker.disconnect();
assert.strictEqual(worker, w, 'did not return a reference');
assert.strictEqual(worker, w, '${worker.id} did not return a reference');

jasnell Oct 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: This needs backticks on the string literal rather than single quote marks.

apapirovski commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/10980/

ping @jasnell @BridgeAR

apapirovski approved these changes Oct 25, 2017
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott approved these changes Oct 25, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 28, 2017
test: imporove assert messages
eefee3e 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: nodejs#16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Oct 28, 2017

Copy link
Copy Markdown
Member

Landed in eefee3e.

Thanks for the contribution! 🎉

Trott closed this Oct 28, 2017
jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: imporove assert messages
c6e484f 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: imporove assert messages
8e05b20 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
test: imporove assert messages
b4af922 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: imporove assert messages
9c9fb97 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: nodejs/node#16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: imporove assert messages
14899b6 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: nodejs/node#16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: imporove assert messages
575fa4a 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: imporove assert messages
5adc352 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: imporove assert messages
58fe9b4 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: #16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
test: imporove assert messages
a0c3019 
Improve assert messages in test-cluster-worker-disconnect.js.

PR-URL: nodejs/node#16021
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
BridgeAR BridgeAR left review comments
Trott Trott approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL