FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

child_process: use internal/errors by tniessen · Pull Request #14009 · nodejs/node · GitHub

/ node Public

child_process: use internal/errors - #14009

Closed
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:child-proc
ConversationCommits (2)ChecksFiles changed
Closed

child_process: use internal/errors#14009
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:child-proc

Conversation

tniessen commented Jun 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Jun 30, 2017

tniessen commented Jun 30, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8901/

tniessen added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 30, 2017
tniessen self-assigned this Jun 30, 2017
jasnell mentioned this pull request Jun 30, 2017
Closed
80 tasks
Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 30, 2017
lpinca reviewed Jul 1, 2017
View reviewed changes
Comment thread lib/internal/child_process.js Outdated
} else if (options !== undefined &&
(options === null || typeof options !== 'object')) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object');
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object',

lpinca Jul 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is 'Object' capitalized here?

tniessen Jul 1, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was like that before, should I change it?

lpinca Jul 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah I noticed but few lines above (260) it is in lowercase. I'd make them consistent.

tniessen commented Jul 2, 2017

Copy link
Copy Markdown
Member Author

@nodejs/ctc due to semverity

mcollina approved these changes Jul 2, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM as semver-major

tniessen added a commit that referenced this pull request Jul 3, 2017
child_process: use internal/errors
fe730d3 
PR-URL: #14009
Refs: #11273
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

tniessen commented Jul 3, 2017

Copy link
Copy Markdown
Member Author

Landed in fe730d3. CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7044/

tniessen closed this Jul 3, 2017
jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
+2 more reviewers
refack refack approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tniessen

Labels

child_process Issues and PRs related to the child_process subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL