FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Temp revert 44483b6 by refack · Pull Request #14142 · nodejs/node · GitHub

/ node Public

Temp revert 44483b6 - #14142

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:temp-revert-44483b6
Jul 9, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Temp revert 44483b6#14142
refack merged 1 commit into
nodejs:masterfrom
refack:temp-revert-44483b6

Conversation

refack commented Jul 9, 2017

Copy link
Copy Markdown
Contributor

Ref: #14099
Fixes: #14141

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,process

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 9, 2017
refack force-pushed the temp-revert-44483b6 branch from eb5f8ba to 1701813 Compare July 9, 2017 03:52
refack mentioned this pull request Jul 9, 2017
Closed
Trott approved these changes Jul 9, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

refack commented Jul 9, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-commit/11031/
I want to land this later today if there are no objections.

mscdex added process Issues and PRs related to the process subsystem. windows Issues and PRs related to the Windows platform. labels Jul 9, 2017
refack force-pushed the temp-revert-44483b6 branch from 1701813 to 7c19247 Compare July 9, 2017 17:06
Revert "test: improve test-process-kill-null for Windows"
d69ecc6 
This reverts commit 44483b6.

PR-URL: nodejs#14142
Fixes: nodejs#14141
Refs: nodejs#14099
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack force-pushed the temp-revert-44483b6 branch from 7c19247 to d69ecc6 Compare July 9, 2017 17:08
refack merged commit d69ecc6 into nodejs:master Jul 9, 2017

refack commented Jul 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

1 run windows CI - https://ci.nodejs.org/job/node-test-commit-windows-fanned/10289/ ✔️
100 run stress - https://ci.nodejs.org/job/node-stress-single-test/1316/ https://ci.nodejs.org/job/node-stress-single-test/1317/

refack deleted the temp-revert-44483b6 branch July 9, 2017 17:14
jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: new flakiness in test-process-kill-null.js

7 participants

Back | FazBrowse Home | New Git URL