FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors, url: port url errors to internal/errors by starkwang · Pull Request #13963 · nodejs/node · GitHub

/ node Public

errors, url: port url errors to internal/errors - #13963

Closed
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:url-internal-error
ConversationCommits (1)ChecksFiles changed
Closed

errors, url: port url errors to internal/errors#13963
starkwang wants to merge 1 commit into
nodejs:masterfrom
starkwang:url-internal-error

Conversation

starkwang commented Jun 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

There is already a PR (#11360) for this migration, but it seems to be out-of-date and deprecated. So I make a new one.

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url, test

nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Jun 28, 2017

TimothyGu commented Jun 29, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8857/

Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently.

refack added errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. labels Jun 29, 2017
jasnell reviewed Jun 29, 2017
View reviewed changes
Comment thread test/parallel/test-url-format-invalid-input.js Outdated

jasnell Jun 29, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: line up the strings here.

starkwang Jun 29, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed

jasnell reviewed Jun 29, 2017
View reviewed changes
Comment thread test/parallel/test-url-parse-invalid-input.js Outdated

jasnell Jun 29, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

long line here?

starkwang Jun 29, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK, I fix it.

starkwang force-pushed the url-internal-error branch from e0d434d to 9e4763b Compare June 29, 2017 04:01
starkwang force-pushed the url-internal-error branch from 9e4763b to b630e47 Compare June 29, 2017 04:03
starkwang mentioned this pull request Jun 29, 2017
Closed
80 tasks
mhdawson approved these changes Jun 29, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Jun 30, 2017

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/8892/

refack pushed a commit to refack/node that referenced this pull request Jul 2, 2017
errors,url: port url errors to internal/errors
473f0ef 
PR-URL: nodejs#13963
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack commented Jul 2, 2017

Copy link
Copy Markdown
Contributor

Landed in 473f0ef

refack closed this Jul 2, 2017

refack commented Jul 2, 2017

Copy link
Copy Markdown
Contributor

Extra sanity run on master: https://ci.nodejs.org/job/node-test-commit/10881/

starkwang mentioned this pull request Aug 8, 2017
Closed
4 tasks
jasnell mentioned this pull request Oct 30, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+3 more reviewers
refack refack approved these changes
TimothyGu TimothyGu approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL