FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

errors, url: migrate to use internal/errors.js by bougarfaoui · Pull Request #11360 · nodejs/node · GitHub

/ node Public

errors, url: migrate to use internal/errors.js - #11360

Closed
bougarfaoui wants to merge 5 commits into
nodejs:masterfrom
bougarfaoui:internal-error-url
ConversationCommits (5)ChecksFiles changed
Closed

errors, url: migrate to use internal/errors.js#11360
bougarfaoui wants to merge 5 commits into
nodejs:masterfrom
bougarfaoui:internal-error-url

Conversation

bougarfaoui commented Feb 13, 2017

Copy link
Copy Markdown

Migrate url.js to use internal/errors.js

Refs: #11273

cc @jasnell .

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, url

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. url Issues and PRs related to the legacy built-in url module. labels Feb 13, 2017
jasnell mentioned this pull request Feb 14, 2017
Closed
80 tasks
joyeecheung reviewed Feb 14, 2017
View reviewed changes
Comment thread lib/url.js Outdated
Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
if (typeof url !== 'string') {
throw new TypeError('Parameter "url" must be a string, not ' + typeof url);
throw new errors.TypeError('ERR_INVALID_ARG_TYPE','url','String',url);

joyeecheung Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Linter should complain here, there needs to be a space following the comma. Can you run make lint to check this?

Comment thread lib/url.js Outdated
} else if (typeof obj !== 'object' || obj === null) {
throw new TypeError('Parameter "urlObj" must be an object, not ' +
(obj === null ? 'null' : typeof obj));
throw new errors.TypeError('ERR_INVALID_ARG_TYPE','obj','Object',obj);

joyeecheung Feb 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ditto.

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017
jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017

fhinkel commented May 23, 2017

Copy link
Copy Markdown
Contributor

@bougarfaoui Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be one commit, right?). Thanks!

fhinkel reviewed May 23, 2017
View reviewed changes

fhinkel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are there any tests that cover these changes?

fhinkel added the stalled Issues and PRs that are stalled. label Jun 7, 2017

fhinkel commented Jun 28, 2017

Copy link
Copy Markdown
Contributor

I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed.

fhinkel closed this Jun 28, 2017
starkwang mentioned this pull request Jun 28, 2017
Closed
3 tasks

refack commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

I'll follow up

refack reopened this Jul 19, 2017
refack removed blocked PRs that are blocked by other issues or PRs. stalled Issues and PRs that are stalled. labels Jul 19, 2017
refack self-assigned this Jul 19, 2017

starkwang commented Aug 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

The errors in url module have been migrated in #13963.
So I think this PR should be closed.

refack commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

Done

refack closed this Aug 8, 2017
refack removed their assignment Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung left review comments
+1 more reviewer
fhinkel fhinkel left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL