test: fix assert.throws in test-http-invalid-urls - #15678
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
lpinca
approved these changes
Sep 29, 2017
Comment thread
test/parallel/test-http-invalid-urls.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: how about replacing this with common.mustNotCall()?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Sure. And while I'm at it, I can add { and } around the arrow function body because there's no need for it to implicitly return a value.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Found other problems in the process. Refactored/fixed/commented in the commit message.
Sorry, something went wrong.
hiroppy
approved these changes
Sep 29, 2017
cjihrig
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
Trott
force-pushed
the
assert-throws-booboo
branch
from
f19a178 to
5db3a8b
Compare
September 29, 2017 22:04
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`.
Trott
force-pushed
the
assert-throws-booboo
branch
from
5db3a8b to
a263630
Compare
September 29, 2017 22:05
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
BridgeAR
approved these changes
Sep 30, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 1, 2017
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`. PR-URL: #15678 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Contributor
|
When cherry-picked to 8.x this test is failing. Could you please backport |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@MylesBorins The test change is dependent on #14423 which is semver-major. I'll label this "dont-land" on 8, 6, and 4. |
Sorry, something went wrong.
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`. PR-URL: nodejs/node#15678 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the second argument to assert.throws() is a string, it is not
treated as the expected error message but rather the message that the
assertion should display if no error is thrown. Ths change fixes that
error in test-http-invalid-urls.js.
Instead of skipping the test when there is no crypto, the test is now
run but with http only. https is skipped.
Logging was fixed. Previously, errors would be written out as being in
the [object Object] module rather than http or https.
Checklist
Affected core subsystem(s)
test