FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix ordering error in errors.md by Trott · Pull Request #13274 · nodejs/node · GitHub

/ node Public

doc: fix ordering error in errors.md - #13274

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:error-in-errors
Closed

doc: fix ordering error in errors.md#13274
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:error-in-errors

Conversation

Trott commented May 29, 2017

Copy link
Copy Markdown
Member

/cc @TimothyGu

Checklist
Affected core subsystem(s)

doc errors

Trott added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 29, 2017
nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 29, 2017

Trott commented May 31, 2017

Copy link
Copy Markdown
Member Author

Landed in 102e1aa

Trott closed this May 31, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 31, 2017
PR-URL: nodejs#13274
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jun 5, 2017

Copy link
Copy Markdown
Member

If any part of this needs to be backported to v8.x, then a separate backport PR should be opened.

Trott commented Jun 5, 2017

Copy link
Copy Markdown
Member Author

@jasnell This should land cleanly on 8.x as long as it lands after 234353a. If that commit is not landing on 8.x, then this one is not needed on 8.x either. If it is landing on 8.x, this one is needed.

jasnell commented Jun 5, 2017

Copy link
Copy Markdown
Member

234353a was a semver-major that I do not believe landed in time to make the 8.x cut so I think we're good.

Trott deleted the error-in-errors branch January 13, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL