FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use process.features.debug in common module by Trott · Pull Request #16537 · nodejs/node · GitHub

/ node Public

test: use process.features.debug in common module - #16537

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:use-process-features
ConversationCommits (1)ChecksFiles changed
Closed

test: use process.features.debug in common module#16537
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:use-process-features

Conversation

Trott commented Oct 26, 2017

Copy link
Copy Markdown
Member

Replace process.config.target_defaults.default_configuration check with
process.features.debug.

Refs: #4431 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: use process.features.debug in common module
745e00b 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

Refs: nodejs#4431 (comment)
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2017

Trott commented Oct 26, 2017

Copy link
Copy Markdown
Member Author

ping @skomski

jasnell reviewed Oct 27, 2017
View reviewed changes
Comment thread test/common/index.js

exports.platformTimeout = function(ms) {
if (process.config.target_defaults.default_configuration === 'Debug')
if (process.features.debug)

jasnell Oct 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

just keep in mind that process.features is mutable by end users...

joyeecheung commented Oct 27, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11019/

Trott commented Oct 27, 2017

Copy link
Copy Markdown
Member Author

Lone CI failure is build related.

Trott commented Oct 27, 2017

Copy link
Copy Markdown
Member Author

Landed in 98eab4a

Trott closed this Oct 27, 2017
Trott added a commit to Trott/io.js that referenced this pull request Oct 27, 2017
test: use process.features.debug in common module
98eab4a 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs#16537
Ref: nodejs#4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

When was process.features added? 🤔 Why isn't it documented?

jasnell commented Oct 27, 2017

Copy link
Copy Markdown
Member

git blame says six years ago: aa0308d

jasnell commented Oct 27, 2017

Copy link
Copy Markdown
Member

(there's a certain irony in process.features not being documented)

jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: use process.features.debug in common module
4c737e6 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: use process.features.debug in common module
0121d59 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
test: use process.features.debug in common module
ea32d0e 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: use process.features.debug in common module
95e4120 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: use process.features.debug in common module
8cc7b17 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: use process.features.debug in common module
810a89c 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: use process.features.debug in common module
3f60021 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: use process.features.debug in common module
8663b05 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: #16537
Ref: #4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
test: use process.features.debug in common module
b83a9d4 
Replace process.config.target_defaults.default_configuration check with
process.features.debug.

PR-URL: nodejs/node#16537
Ref: nodejs/node#4431 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott deleted the use-process-features branch January 13, 2022 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL