FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: deprecate vm.runInDebugContext by joshgav · Pull Request #12815 · nodejs/node · GitHub

/ node Public

src: deprecate vm.runInDebugContext - #12815

Closed
joshgav wants to merge 2 commits into
nodejs:masterfrom
joshgav:deprecate-debugcontext-runtime
ConversationCommits (2)ChecksFiles changed
Closed

src: deprecate vm.runInDebugContext#12815
joshgav wants to merge 2 commits into
nodejs:masterfrom
joshgav:deprecate-debugcontext-runtime

Conversation

joshgav commented May 3, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Runtime deprecation of vm.runInDebugContext. To land in v9.x.

joshgav added debugger vm Issues and PRs related to the vm subsystem. labels May 3, 2017
nodejs-github-bot added util Issues and PRs related to the built-in util module. vm Issues and PRs related to the vm subsystem. labels May 3, 2017
joshgav mentioned this pull request May 3, 2017
Closed
4 tasks
joshgav requested a review from ofrobots May 3, 2017 19:17

Fishrock123 commented May 3, 2017

Copy link
Copy Markdown
Contributor

Will there be no similar behavior?

TimothyGu suggested changes May 4, 2017
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The deprecation status in doc/api/deprecations.md also needs to be changed to Runtime.

Comment thread doc/api/vm.md Outdated

TimothyGu May 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change should go in separately with v8.x.

jasnell May 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be REPLACEME rather than listing a specific version here.

addaleax Oct 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@TimothyGu Done (but deprecated: v8.0.0 is correct since that’s when we docs-deprecated)

Comment thread test/parallel/test-vm-debug-context.js Outdated

TimothyGu May 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why const _?

addaleax Oct 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@TimothyGu done

addaleax commented May 23, 2017

Copy link
Copy Markdown
Member

ping @joshgav

targos mentioned this pull request May 30, 2017
Merged

fhinkel commented Aug 3, 2017

Copy link
Copy Markdown
Contributor

@joshgav can we close this in favor of #13295? I'm trying to figure out the status of deprecating vm.runInDebugContext() but PRs are sending me in circles.

TimothyGu commented Aug 31, 2017

Copy link
Copy Markdown
Member

@fhinkel Yes I believe so.

TimothyGu closed this Aug 31, 2017

targos commented Oct 21, 2017

Copy link
Copy Markdown
Member

Should we reopen since #13295 won't be in v9?

addaleax commented Oct 22, 2017

Copy link
Copy Markdown
Member

@targos yup

addaleax reopened this Oct 22, 2017
addaleax added this to the 9.0.0 milestone Oct 22, 2017
addaleax force-pushed the deprecate-debugcontext-runtime branch from 1894455 to 66fa03d Compare October 22, 2017 14:39

addaleax commented Oct 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

I don’t think @joshgav is very active right now, so I’ve rebased and force-pushed this.

@nodejs/tsc This needs to be in Node 9, ptal

CI: https://ci.nodejs.org/job/node-test-commit/13371/

(edit: self-assignment to keep track, shouldn’t stop anybody from merging)

addaleax self-assigned this Oct 22, 2017
targos added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v4.x labels Oct 23, 2017

targos commented Oct 23, 2017

Copy link
Copy Markdown
Member

I just pushed a commit to change the deprecation type in the documentation.

addaleax commented Oct 23, 2017

Copy link
Copy Markdown
Member

Landed in 88e55fe

addaleax closed this Oct 23, 2017
addaleax pushed a commit that referenced this pull request Oct 23, 2017
vm: deprecate vm.runInDebugContext
88e55fe 
PR-URL: #12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
vm: deprecate vm.runInDebugContext
4192ffa 
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
vm: deprecate vm.runInDebugContext
09d80f2 
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
ofrobots Awaiting requested review from ofrobots
+2 more reviewers
TimothyGu TimothyGu requested changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

addaleax

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL