FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add block scoping to test-assert-deep by Trott · Pull Request #16532 · nodejs/node · GitHub

/ node Public

test: add block scoping to test-assert-deep - #16532

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:block-scope-test-assert-deep
ConversationCommits (1)ChecksFiles changed
Closed

test: add block scoping to test-assert-deep#16532
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:block-scope-test-assert-deep

Conversation

Trott commented Oct 26, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test assert

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2017
mscdex added the assert Issues and PRs related to the assert subsystem. label Oct 27, 2017

gireeshpunathil commented Oct 27, 2017

Copy link
Copy Markdown
Member

@Trott - can you please provide a rational ( a one liner may be) for doing this? Is it readability or something else? (such as performance / footprint etc.? are we expecting gc to kick-in between the test run)

joyeecheung commented Oct 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@gireeshpunathil I think it's mostly for readability, also there will be fewer conflicts of variable names.

joyeecheung commented Oct 27, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11018/

Trott commented Oct 27, 2017

Copy link
Copy Markdown
Member Author

@gireeshpunathil It's primarily to avoid unintentional side effects between test cases. (More can be done.) I'll add that to the commit message.

test: add block scoping to test-assert-deep
a6e1740 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.
Trott force-pushed the block-scope-test-assert-deep branch from 4a711cc to a6e1740 Compare October 27, 2017 16:56
gibfahn approved these changes Oct 28, 2017
View reviewed changes

gibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I find this much easier to read (tests are clearly separated).

gireeshpunathil commented Oct 28, 2017

Copy link
Copy Markdown
Member

thanks @Trott and @joyeecheung for clarifying

joyeecheung commented Oct 28, 2017

Copy link
Copy Markdown
Member

CI failures are unrelated, can go ahead an land this now if we don't want to wait for 72 hours.

tniessen pushed a commit that referenced this pull request Oct 29, 2017
test: add block scoping to test-assert-deep
203b548 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

tniessen commented Oct 29, 2017

Copy link
Copy Markdown
Member

Landed in 203b548.

tniessen closed this Oct 29, 2017
jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: add block scoping to test-assert-deep
0ec47de 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
test: add block scoping to test-assert-deep
170f2eb 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
test: add block scoping to test-assert-deep
a628455 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: add block scoping to test-assert-deep
47debc3 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
test: add block scoping to test-assert-deep
7280e57 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
test: add block scoping to test-assert-deep
c060c87 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Trott deleted the block-scope-test-assert-deep branch January 13, 2022 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes
JungMinu JungMinu approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL