FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: http2.connect accepts net & tls options by apapirovski · Pull Request #16576 · nodejs/node · GitHub

/ node Public

doc: http2.connect accepts net & tls options - #16576

Closed
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:doc-http2-connect-options
ConversationCommits (1)ChecksFiles changed
Closed

doc: http2.connect accepts net & tls options#16576
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:doc-http2-connect-options

Conversation

apapirovski commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

Makes it clear that http2.connect can accept all the same options as net.connect and tls.connect since there seems to be some confusion around this.

Fixes: #15405

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

apapirovski added the doc Issues and PRs related to the documentations. label Oct 28, 2017
nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Oct 28, 2017
apapirovski requested a review from mcollina October 28, 2017 18:43
cjihrig approved these changes Oct 29, 2017
View reviewed changes
Comment thread doc/api/http2.md
* `createConnection` {Function} An optional callback that receives the `URL`
instance passed to `connect` and the `options` object, and returns any
[`Duplex`][] stream that is to be used as the connection for this session.
* ...: Any [`net.connect()`][] or [`tls.connect()`][] options can be provided.

cjihrig Oct 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add backticks to the ....

apapirovski Oct 29, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The current version matches doc/api/tls.md where it's used like this 3 times. (Also one other place in the http2 doc.)

mcollina approved these changes Oct 29, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

apapirovski commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

I assume this doesn't need 48 hours but please speak up if you disagree. Will be merging within the next hour.

jasnell approved these changes Oct 29, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 for not waiting the 48 hours

apapirovski commented Oct 29, 2017

Copy link
Copy Markdown
Contributor Author

Landed in 8a9be41

apapirovski deleted the doc-http2-connect-options branch October 29, 2017 16:56
apapirovski added a commit that referenced this pull request Oct 29, 2017
doc: http2.connect accepts net & tls options
8a9be41 
PR-URL: #16576
Fixes: #15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
doc: http2.connect accepts net & tls options
c71c521 
PR-URL: #16576
Fixes: #15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
doc: http2.connect accepts net & tls options
8cb59bf 
PR-URL: #16576
Fixes: #15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
doc: http2.connect accepts net & tls options
1b08ae8 
PR-URL: #16576
Fixes: #15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
doc: http2.connect accepts net & tls options
42ca268 
PR-URL: nodejs/node#16576
Fixes: nodejs/node#15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
doc: http2.connect accepts net & tls options
1915f41 
PR-URL: nodejs/node#16576
Fixes: nodejs/node#15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
doc: http2.connect accepts net & tls options
a850b4a 
PR-URL: nodejs/node#16576
Fixes: nodejs/node#15405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
daxlab daxlab approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http2 - cannot use client certificate and key

8 participants

Back | FazBrowse Home | New Git URL