FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix wrong history entry in deepStrictEqual by hisener · Pull Request #15381 · nodejs/node · GitHub

/ node Public

doc: fix wrong history entry in deepStrictEqual - #15381

Closed
hisener wants to merge 1 commit into
nodejs:masterfrom
hisener:fix-assert-api-doc
Closed

doc: fix wrong history entry in deepStrictEqual#15381
hisener wants to merge 1 commit into
nodejs:masterfrom
hisener:fix-assert-api-doc

Conversation

hisener commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Fixes: #15379

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

None

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 13, 2017
Comment thread doc/api/assert.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be kept as REPLACEME because it is a semver-major change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok

jasnell pushed a commit that referenced this pull request Sep 15, 2017
PR-URL: #15381
Fixes: #15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jasnell commented Sep 15, 2017

Copy link
Copy Markdown
Member

Landed in a591610

jasnell closed this Sep 15, 2017
hisener deleted the fix-assert-api-doc branch September 15, 2017 17:29
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc - wrong history entry

6 participants


Back | FazBrowse Home | New Git URL