| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent e026132 commit 7c2a9bb
6 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ | |||
| 11 | 11 | #define V8_MAJOR_VERSION 6 | |
| 12 | 12 | #define V8_MINOR_VERSION 2 | |
| 13 | 13 | #define V8_BUILD_NUMBER 414 | |
| 14 | - #define V8_PATCH_LEVEL 44 | ||
| 14 | + #define V8_PATCH_LEVEL 46 | ||
| 15 | 15 | ||
| 16 | 16 | // Use 1 for candidates and 0 otherwise. | |
| 17 | 17 | // (Boolean macro values are not supported by all preprocessors.) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1895,6 +1895,7 @@ void Debug::ProcessCompileEvent(v8::DebugEvent event, Handle<Script> script) { | |||
| 1895 | 1895 | HandleScope scope(isolate_); | |
| 1896 | 1896 | PostponeInterruptsScope postpone(isolate_); | |
| 1897 | 1897 | DisableBreak no_recursive_break(this); | |
| 1898 | + AllowJavascriptExecution allow_script(isolate_); | ||
| 1898 | 1899 | debug_delegate_->ScriptCompiled(ToApiHandle<debug::Script>(script), | |
| 1899 | 1900 | live_edit_enabled(), | |
| 1900 | 1901 | event != v8::AfterCompile); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -411,9 +411,9 @@ config file change, however. | |||
| 411 | 411 | ### Non-goals | |
| 412 | 412 | ||
| 413 | 413 | * MB is not intended to replace direct invocation of GN or GYP for | |
| 414 | - complicated build scenarios (aka ChromeOS), where multiple flags need | ||
| 414 | + complicated build scenarios (a.k.a. Chrome OS), where multiple flags need | ||
| 415 | 415 | to be set to user-defined paths for specific toolchains (e.g., where | |
| 416 | - ChromeOS needs to specify specific board types and compilers). | ||
| 416 | + Chrome OS needs to specify specific board types and compilers). | ||
| 417 | 417 | ||
| 418 | 418 | * MB is not intended at this time to be something developers use frequently, | |
| 419 | 419 | or to add a lot of features to. We hope to be able to get rid of it once | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,7 +20,7 @@ For more discussion of MB, see also [the design spec](design_spec.md). | |||
| 20 | 20 | ||
| 21 | 21 | ### `mb analyze` | |
| 22 | 22 | ||
| 23 | - `mb analyze` is responsible for determining what targets are affected by | ||
| 23 | + `mb analyze` is reponsible for determining what targets are affected by | ||
| 24 | 24 | a list of files (e.g., the list of files in a patch on a trybot): | |
| 25 | 25 | ||
| 26 | 26 | ``` | |
@@ -45,12 +45,12 @@ a single object with the following fields: | |||
| 45 | 45 | reflect the stuff we might want to build *in addition to* the list | |
| 46 | 46 | passed in `test_targets`. Targets in this list will be treated | |
| 47 | 47 | specially, in the following way: if a given target is a "meta" | |
| 48 | - (GN: group, GYP: none) target like 'blink_tests' or | ||
| 49 | - 'chromium_builder_tests', or even the ninja-specific 'all' target, | ||
| 50 | - then only the *dependencies* of the target that are affected by | ||
| 51 | - the modified files will be rebuilt (not the target itself, which | ||
| 52 | - might also cause unaffected dependencies to be rebuilt). An empty | ||
| 53 | - list will be treated as if there are no additional targets to build. | ||
| 48 | + (GN: group, GYP: none) target like 'blink_tests' or or even the | ||
| 49 | + ninja-specific 'all' target, then only the *dependencies* of the | ||
| 50 | + target that are affected by the modified files will be rebuilt | ||
| 51 | + (not the target itself, which might also cause unaffected dependencies | ||
| 52 | + to be rebuilt). An empty list will be treated as if there are no additional | ||
| 53 | + targets to build. | ||
| 54 | 54 | Empty lists for both `test_targets` and `additional_compile_targets` | |
| 55 | 55 | would cause no work to be done, so will result in an error. | |
| 56 | 56 | * `targets`: a legacy field that resembled a union of `compile_targets` | |
@@ -167,6 +167,21 @@ The `-f/--config-file` and `-q/--quiet` flags work as documented for | |||
| 167 | 167 | This is mostly useful as a presubmit check and for verifying changes to | |
| 168 | 168 | the config file. | |
| 169 | 169 | ||
| 170 | + ### `mb gerrit-buildbucket-config` | ||
| 171 | + | ||
| 172 | + Generates a gerrit buildbucket configuration file and prints it to | ||
| 173 | + stdout. This file contains the list of trybots shown in gerrit's UI. | ||
| 174 | + | ||
| 175 | + The master copy of the buildbucket.config file lives | ||
| 176 | + in a separate branch of the chromium repository. Run `mb | ||
| 177 | + gerrit-buildbucket-config > buildbucket.config.new && git fetch origin | ||
| 178 | + refs/meta/config:refs/remotes/origin/meta/config && git checkout | ||
| 179 | + -t -b meta_config origin/meta/config && mv buildbucket.config.new | ||
| 180 | + buildbucket.config` to update the file. | ||
| 181 | + | ||
| 182 | + Note that after committing, `git cl upload` will not work. Instead, use `git | ||
| 183 | + push origin HEAD:refs/for/refs/meta/config` to upload the CL for review. | ||
| 184 | + | ||
| 170 | 185 | ## Isolates and Swarming | |
| 171 | 186 | ||
| 172 | 187 | `mb gen` is also responsible for generating the `.isolate` and | |
| Back | FazBrowse Home | New Git URL |
0 commit comments