FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patch V8 to 6.2.414.46 by MylesBorins · Pull Request #17206 · nodejs/node · GitHub

/ node Public

deps: patch V8 to 6.2.414.46 - #17206

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.2-bump
ConversationCommits (1)ChecksFiles changed
Closed

deps: patch V8 to 6.2.414.46#17206
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.2-bump

Conversation

MylesBorins commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 22, 2017

MylesBorins commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/11606/
v8-ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/1064/

MylesBorins commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

@nodejs/v8 it looks like this patch is breaking some stuff on master, specifically v8tests.inspector/debugger/caught-uncaught-exceptions --nohard-abort

😢

hashseed commented Nov 22, 2017

Copy link
Copy Markdown
Member

I wonder how that can happen, considering how upstream works fine.

targos commented Nov 23, 2017

Copy link
Copy Markdown
Member

Master is already broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/1072/
This patch is not related.

MylesBorins commented Nov 23, 2017 via email

Copy link
Copy Markdown
Contributor Author

targos commented Nov 23, 2017

Copy link
Copy Markdown
Member

@MylesBorins yes. See #17270

MylesBorins commented Nov 26, 2017

Copy link
Copy Markdown
Contributor Author

As the single failure for this is a known failure do you think it makes sense for us to just land this?

Can I please get some sign off on this @targos or @nodejs/v8

MylesBorins commented Nov 26, 2017

Copy link
Copy Markdown
Contributor Author

landed in 04aab13

MylesBorins added a commit that referenced this pull request Nov 26, 2017
deps: patch V8 to 6.2.414.46
04aab13 
Refs: v8/v8@6.2.414.44...6.2.414.46
PR-URL: #17206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Dec 12, 2017
deps: patch V8 to 6.2.414.46
d046eed 
Refs: v8/v8@6.2.414.44...6.2.414.46
PR-URL: #17206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Dec 12, 2017
deps: patch V8 to 6.2.414.46
7c2a9bb 
Refs: v8/v8@6.2.414.44...6.2.414.46
PR-URL: #17206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Dec 12, 2017
2017-12-12 Version 9.3.0 (Current)
3c42f73 
Notable changes:

* async\_hooks:
  - add trace events to async_hooks (Andreas Madsen)
    #15538
  - add provider types for net server (Andreas Madsen)
    #17157
* console:
  - console.debug can now be used outside of the inspector
    (Benjamin Zaslavsky) #17033
* deps:
  - upgrade libuv to 1.18.0 (cjihrig)
    #17282
  - patch V8 to 6.2.414.46 (Myles Borins)
    #17206
* module:
  - module.builtinModules will return a list of built in modules
    (Jon Moss) #16386
* n-api:
  - add helper for addons to get the event loop (Anna Henningsen)
    #17109
* process:
  - process.setUncaughtExceptionCaptureCallback can now be used to
    customize behavior for `--abort-on-uncaught-exception`
    (Anna Henningsen) #17159
  - A signal handler is now able to receive the signal code that
    triggered the handler. (Robert Rossmann)
    #15606
* src:
  - embedders can now use Node::CreatePlatform to create an instance of
    NodePlatform (Cheng Zhao)
    #16981
* stream:
  - writable.writableHighWaterMark and readable.readableHighWaterMark
    will return the values the stream object was instantiated with
    (Calvin Metcalf) #12860
* **Added new collaborators**
  * [maclover7](https://github.com/maclover7) Jon Moss
  * [guybedford](https://github.com/guybedford) Guy Bedford
  * [hashseed](https://github.com/hashseed) Yang Guo

PR-URL: Coming Soon
MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins added a commit that referenced this pull request Dec 12, 2017
2017-12-12 Version 9.3.0 (Current)
08941e9 
Notable changes:

* async\_hooks:
  - add trace events to async_hooks (Andreas Madsen)
    #15538
  - add provider types for net server (Andreas Madsen)
    #17157
* console:
  - console.debug can now be used outside of the inspector
    (Benjamin Zaslavsky) #17033
* deps:
  - upgrade libuv to 1.18.0 (cjihrig)
    #17282
  - patch V8 to 6.2.414.46 (Myles Borins)
    #17206
* module:
  - module.builtinModules will return a list of built in modules
    (Jon Moss) #16386
* n-api:
  - add helper for addons to get the event loop (Anna Henningsen)
    #17109
* process:
  - process.setUncaughtExceptionCaptureCallback can now be used to
    customize behavior for `--abort-on-uncaught-exception`
    (Anna Henningsen) #17159
  - A signal handler is now able to receive the signal code that
    triggered the handler. (Robert Rossmann)
    #15606
* src:
  - embedders can now use Node::CreatePlatform to create an instance of
    NodePlatform (Cheng Zhao)
    #16981
* stream:
  - writable.writableHighWaterMark and readable.readableHighWaterMark
    will return the values the stream object was instantiated with
    (Calvin Metcalf) #12860
* **Added new collaborators**
  * [maclover7](https://github.com/maclover7) Jon Moss
  * [guybedford](https://github.com/guybedford) Guy Bedford
  * [hashseed](https://github.com/hashseed) Yang Guo

PR-URL: #17631
MylesBorins added a commit that referenced this pull request Dec 12, 2017
2017-12-12 Version 9.3.0 (Current)
a893e79 
Notable changes:

* async\_hooks:
  - add trace events to async_hooks (Andreas Madsen)
    #15538
  - add provider types for net server (Andreas Madsen)
    #17157
* console:
  - console.debug can now be used outside of the inspector
    (Benjamin Zaslavsky) #17033
* deps:
  - upgrade libuv to 1.18.0 (cjihrig)
    #17282
  - patch V8 to 6.2.414.46 (Myles Borins)
    #17206
* module:
  - module.builtinModules will return a list of built in modules
    (Jon Moss) #16386
* n-api:
  - add helper for addons to get the event loop (Anna Henningsen)
    #17109
* process:
  - process.setUncaughtExceptionCaptureCallback can now be used to
    customize behavior for `--abort-on-uncaught-exception`
    (Anna Henningsen) #17159
  - A signal handler is now able to receive the signal code that
    triggered the handler. (Robert Rossmann)
    #15606
* src:
  - embedders can now use Node::CreatePlatform to create an instance of
    NodePlatform (Cheng Zhao)
    #16981
* stream:
  - writable.writableHighWaterMark and readable.readableHighWaterMark
    will return the values the stream object was instantiated with
    (Calvin Metcalf) #12860
* **Added new collaborators**
  * [maclover7](https://github.com/maclover7) Jon Moss
  * [guybedford](https://github.com/guybedford) Guy Bedford
  * [hashseed](https://github.com/hashseed) Yang Guo

PR-URL: #17631
Justkant reviewed Dec 20, 2017
View reviewed changes
Comment thread deps/v8/tools/mb/docs/user_guide.md
the modified files will be rebuilt (not the target itself, which
might also cause unaffected dependencies to be rebuilt). An empty
list will be treated as if there are no additional targets to build.
(GN: group, GYP: none) target like 'blink_tests' or or even the

Justkant Dec 20, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typo: or or

OwnageIsMagic reviewed Dec 30, 2017
View reviewed changes
Comment thread deps/v8/tools/mb/docs/user_guide.md
### `mb analyze`

`mb analyze` is responsible for determining what targets are affected by
`mb analyze` is reponsible for determining what targets are affected by

OwnageIsMagic Dec 30, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

which repo this typos should be reported?

targos Jan 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the V8 project: https://bugs.chromium.org/p/v8/issues/list

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fhinkel Awaiting requested review from fhinkel
3 more reviewers
targos targos approved these changes
Justkant Justkant left review comments
OwnageIsMagic OwnageIsMagic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL