test: move to for of loop in test-http-hostname-typechecking.js · nodejs/node@7f301e0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7f301e0

Browse filesBrowse the repository at this point in the historyBrowse files

Puppo

authored and

richardlau

committed

test: move to for of loop in test-http-hostname-typechecking.js

PR-URL: #50782 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

1 parent c823391 commit 7f301e0
Copy full SHA for 7f301e0

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-hostname-typechecking.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-hostname-typechecking.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-hostname-typechecking.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -36,7 +36,8 @@ vals.forEach((v) => {
36	36	// These values are OK and should not throw synchronously.
37	37	// Only testing for 'hostname' validation so ignore connection errors.
38	38	const dontCare = () => {};
39		- ['', undefined, null].forEach((v) => {
	39	+ const values = ['', undefined, null];
	40	+ for (const v of values) {
40	41	http.request({ hostname: v }).on('error', dontCare).end();
41	42	http.request({ host: v }).on('error', dontCare).end();
42		- });
	43	+ }

0 commit comments

Comments

0 (0)