FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move to for of loop in test-http-hostname-typechecking.js by Puppo · Pull Request #50782 · nodejs/node · GitHub

/ node Public

test: move to for of loop in test-http-hostname-typechecking.js - #50782

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Puppo:refactor/test-http-hostname-typechecking
Dec 22, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: move to for of loop in test-http-hostname-typechecking.js#50782
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Puppo:refactor/test-http-hostname-typechecking

Conversation

Puppo commented Nov 18, 2023 •
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Contributor

your first node.js contribution workshop

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023

ShogunPanda commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

Could you please add the file name in the commit message?

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2023

nodejs-github-bot commented Nov 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55742/

Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 664697b to 9cfac4a Compare November 18, 2023 18:02
Puppo changed the title test: replace foreach to for of loop test: replace foreach with for of loop test-http-hostname-typechecking.js Nov 18, 2023
Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 9cfac4a to 8aa4665 Compare November 18, 2023 18:06

Puppo commented Nov 18, 2023

Copy link
Copy Markdown
Contributor Author

@ShogunPanda done ✅

Puppo force-pushed the refactor/test-http-hostname-typechecking branch from 8aa4665 to c4f84d6 Compare November 21, 2023 12:53
Puppo changed the title test: replace foreach with for of loop test-http-hostname-typechecking.js test: move to for of loop in test-http-hostname-typechecking.js Nov 21, 2023
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55896/

debadree25 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 15, 2023
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56437/

nodejs-github-bot commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56453/

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
nodejs-github-bot merged commit c9fe4b6 into nodejs:main Dec 22, 2023

nodejs-github-bot commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in c9fe4b6

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
test: move to for of loop in test-http-hostname-typechecking.js
88e8651 
PR-URL: #50782
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: move to for of loop in test-http-hostname-typechecking.js
7f301e0 
PR-URL: #50782
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL