Commit 815d59a
test: fix test-memory-usage.js for IBMi
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi
the same way process.memoryUsage().rss does. Allow IBMi to skip the new
assertion.
The test was using a mix of `assert()` and `assert.ok()`. This change
makes it consistently use `assert.ok()`.
PR-URL: #36758
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 0c469b3 commit 815d59a
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,8 +26,11 @@ const assert = require('assert'); | |||
| 26 | 26 | ||
| 27 | 27 | const r = process.memoryUsage(); | |
| 28 | 28 | // On IBMi, the rss memory always returns zero | |
| 29 | - if (!common.isIBMi) | ||
| 29 | + if (!common.isIBMi) { | ||
| 30 | 30 | assert.ok(r.rss > 0); | |
| 31 | + assert.ok(process.memoryUsage.rss() > 0); | ||
| 32 | + } | ||
| 33 | + | ||
| 31 | 34 | assert.ok(r.heapTotal > 0); | |
| 32 | 35 | assert.ok(r.heapUsed > 0); | |
| 33 | 36 | assert.ok(r.external > 0); | |
@@ -39,10 +42,8 @@ if (r.arrayBuffers > 0) { | |||
| 39 | 42 | const ab = new ArrayBuffer(size); | |
| 40 | 43 | ||
| 41 | 44 | const after = process.memoryUsage(); | |
| 42 | - assert(after.external - r.external >= size, | ||
| 43 | - `${after.external} - ${r.external} >= ${size}`); | ||
| 45 | + assert.ok(after.external - r.external >= size, | ||
| 46 | + `${after.external} - ${r.external} >= ${size}`); | ||
| 44 | 47 | assert.strictEqual(after.arrayBuffers - r.arrayBuffers, size, | |
| 45 | 48 | `${after.arrayBuffers} - ${r.arrayBuffers} === ${size}`); | |
| 46 | 49 | } | |
| 47 | - | ||
| 48 | - assert(process.memoryUsage.rss() > 0); | ||
0 commit comments