test: fix test-memory-usage.js for IBMi - #36758
Merged
Trott merged 1 commit intoJan 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
IBMi CI on master (should fail): https://ci.nodejs.org/job/node-test-commit-ibmi/210/ IBMi CI this PR (should pass): https://ci.nodejs.org/job/node-test-commit-ibmi/212/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Jan 3, 2021
Copy link
Copy Markdown
Member
|
cc @nodejs/platform-ibmi |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Jan 4, 2021
watilde
approved these changes
Jan 4, 2021
mhdawson
approved these changes
Jan 4, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: nodejs#36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2021
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi
the same way process.memoryUsage().rss does. Allow IBMi to skip the new
assertion.
The test was using a mix of assert() and assert.ok(). This change
makes it consistently use assert.ok().
Checklist