v14.18.0 release proposal - #39990
Merged
targos merged 421 commits intoSep 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PR-URL: #39082 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
PR-URL: #39127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
When I moved node-inspect into core, I called a lot of things `inspector-cli` that really should have been `debugger`. This is the last of them to be renamed. PR-URL: #39156 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Stick with "repository" instead of using both "repository" and "repo". PR-URL: #39157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Logic in module_job.js assumes detailed stack trace from node_errors.cc which is not populated when --enable-source-maps is set. Fixes #38790 PR-URL: #39017 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
We can remove the Acorn plugins as their features are now supported by default. PR-URL: #39166 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The CSS variables are not in any particular logical order as far as I can tell, with certain items that would seem to go together not grouped. This puts them in alphabetical order. PR-URL: #39169 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #39115 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #39129 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39200 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Use "repository" instead of "repo". This also adjusts capitalization in a header that was already being modified to use "repository" because even I couldn't bring myself to put that in a separate commit. PR-URL: #39179 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In 2016, Ali added the instruction to cc him on particular V8 bugs and the suggestion to contact him for certain problems. However, I'm pretty sure Ali has not been working on V8 for 2+ years at this point. I'm guessing those instructions are obsolete at this point. (I'll ping him in the PR for this change to confirm, though.) Also: Remove a parenthetical and add a comma, because I can't imagine opening a separate pull request to add a comma. (OK, I'm lying, I totally can and if anyone has done that in the past, it's probably me.) PR-URL: #39181 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Remove special V8 maintenance instructions for versions of Node.js prior to 9.0.0. Perform other minor edits in nearby text. PR-URL: #39185 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This commit adds step to CC oss-security@lists.openwall.com as part of the security release process. PR-URL: #39191 Refs: nodejs/TSC#1047 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #39170 Refs: nodejs/remark-preset-lint-node#188 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #39201 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
#36918 landed with references to DEP0150, which is already used for a different deprecation. This commit updates the code to use DEP0151. PR-URL: #37147 Refs: #36918 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
We're about to turn on a requirement for dangling commas. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
PR-URL: #38656 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #39154 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #39211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #39212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39213 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Notable changes: assert: * change status of legacy asserts (James M Snell) #38113 buffer: * (SEMVER-MINOR) introduce Blob (James M Snell) #36811 * (SEMVER-MINOR) add base64url encoding option (Filip Skokan) #36952 child_process: * (SEMVER-MINOR) allow `options.cwd` receive a URL (Khaidi Chu) #38862 * (SEMVER-MINOR) add timeout to spawn and fork (Nitzan Uziely) #37256 * (SEMVER-MINOR) allow promisified exec to be cancel (Carlos Fuentes) #34249 * (SEMVER-MINOR) add 'overlapped' stdio flag (Thiago Padilha) #29412 cli: * (SEMVER-MINOR) add -C alias for --conditions flag (Guy Bedford) #38755 * (SEMVER-MINOR) add --node-memory-debug option (Anna Henningsen) #35537 dns: * (SEMVER-MINOR) add "tries" option to Resolve options (Luan Devecchi) #39610 * (SEMVER-MINOR) allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099 doc: * (SEMVER-MINOR) add missing change to resolver ctor (Luan Devecchi) #39610 * refactor fs docs structure (James M Snell) #37170 errors: * (SEMVER-MINOR) remove experimental from --enable-source-maps (Benjamin Coe) #37362 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028 * (SEMVER-MINOR) allow no-params fsPromises fileHandle read (Nitzan Uziely) #38287 * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) #37490 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * (SEMVER-MINOR) add fsPromises.watch() (James M Snell) #37179 * (SEMVER-MINOR) allow `position` parameter to be a `BigInt` in read and readSync (Darshan Sen) #36190 http2: * (SEMVER-MINOR) add support for sensitive headers (Anna Henningsen) #34145 * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978 inspector: * mark as stable (Gireesh Punathil) #37748 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 * (SEMVER-MINOR) add support for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 net: * (SEMVER-MINOR) introduce net.BlockList (James M Snell) #34625 node-api: * (SEMVER-MINOR) allow retrieval of add-on file name (Gabriel Schulhof) #37195 os: * (SEMVER-MINOR) add os.devNull (Luigi Pinca) #38569 perf_hooks: * (SEMVER-MINOR) introduce createHistogram (James M Snell) #37155 process: * (SEMVER-MINOR) add api to enable source-maps programmatically (legendecas) #39085 * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 * (SEMVER-MINOR) add direct access to rss without iterating pages (Adrien Maret) #34291 readline: * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) #37932 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 repl: * (SEMVER-MINOR) add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 src: * (SEMVER-MINOR) call overload ctor from the original ctor (Darshan Sen) #39768 * (SEMVER-MINOR) add a constructor overload for CallbackScope (Darshan Sen) #39768 * (SEMVER-MINOR) allow to negate boolean CLI flags (Michaël Zasso) #39023 * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 * (SEMVER-MINOR) add maybe versions of EmitExit and EmitBeforeExit (Anna Henningsen) #35486 stream: * (SEMVER-MINOR) add readableDidRead if has been read from (Robert Nagy) #39589 * (SEMVER-MINOR) pipeline accept Buffer as a valid first argument (Nitzan Uziely) #37739 tls: * (SEMVER-MINOR) allow reading data into a static buffer (Andrey Pechkurov) #35753 tools: * (SEMVER-MINOR) add `Worker` to type-parser (James M Snell) #38659 url: * (SEMVER-MINOR) expose urlToHttpOptions utility (Yongsheng Zhang) #35960 util: * (SEMVER-MINOR) expose toUSVString (Robert Nagy) #39814 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add setEnvironmentData/getEnvironmentData (James M Snell) #37486 PR-URL: #39990
targos
force-pushed
the
v14.18.0-proposal
branch
from
f226165 to
7af8896
Compare
September 7, 2021 14:32
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
/cc @ljharb This release adds support for node:-prefixed core modules in require (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2757/nodes=ubuntu1604-64/testReport/junit/(root)/citgm/is_core_module_v2_6_0/) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@targos thanks; i'll update is-core-module/resolve today. What's the timeline for this release? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ljharb I'm aiming for 2021-09-28 (three weeks from now). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
in that case I'll hold off a bit; i've got the code change ready, but please ping me closer to the release and i'll publish it :-) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Apart from is-core-module and resolve, CITGM failures are the same between this PR and v14.17.6. I started an RC build: https://ci-release.nodejs.org/job/iojs+release/7160/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was referenced Sep 14, 2021
3 tasks
Copy link
Copy Markdown
Member
Author
|
The release is in two days. Anyone wants to review? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
/cc @nodejs/releasers @nodejs/lts |
Sorry, something went wrong.
richardlau
approved these changes
Sep 27, 2021
danielleadams
approved these changes
Sep 27, 2021
Copy link
Copy Markdown
Member
|
is-core-module v2.7.0 is published. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Release build: https://ci-release.nodejs.org/job/iojs+release/7205/ |
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Sep 28, 2021
Notable changes: assert: * change status of legacy asserts (James M Snell) #38113 buffer: * (SEMVER-MINOR) introduce Blob (James M Snell) #36811 * (SEMVER-MINOR) add base64url encoding option (Filip Skokan) #36952 child_process: * (SEMVER-MINOR) allow `options.cwd` receive a URL (Khaidi Chu) #38862 * (SEMVER-MINOR) add timeout to spawn and fork (Nitzan Uziely) #37256 * (SEMVER-MINOR) allow promisified exec to be cancel (Carlos Fuentes) #34249 * (SEMVER-MINOR) add 'overlapped' stdio flag (Thiago Padilha) #29412 cli: * (SEMVER-MINOR) add -C alias for --conditions flag (Guy Bedford) #38755 * (SEMVER-MINOR) add --node-memory-debug option (Anna Henningsen) #35537 dns: * (SEMVER-MINOR) add "tries" option to Resolve options (Luan Devecchi) #39610 * (SEMVER-MINOR) allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099 doc: * (SEMVER-MINOR) add missing change to resolver ctor (Luan Devecchi) #39610 * refactor fs docs structure (James M Snell) #37170 errors: * (SEMVER-MINOR) remove experimental from --enable-source-maps (Benjamin Coe) #37362 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028 * (SEMVER-MINOR) allow no-params fsPromises fileHandle read (Nitzan Uziely) #38287 * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) #37490 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * (SEMVER-MINOR) add fsPromises.watch() (James M Snell) #37179 * (SEMVER-MINOR) allow `position` parameter to be a `BigInt` in read and readSync (Darshan Sen) #36190 http2: * (SEMVER-MINOR) add support for sensitive headers (Anna Henningsen) #34145 * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978 inspector: * mark as stable (Gireesh Punathil) #37748 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) #38587 * (SEMVER-MINOR) add support for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 net: * (SEMVER-MINOR) introduce net.BlockList (James M Snell) #34625 node-api: * (SEMVER-MINOR) allow retrieval of add-on file name (Gabriel Schulhof) #37195 os: * (SEMVER-MINOR) add os.devNull (Luigi Pinca) #38569 perf_hooks: * (SEMVER-MINOR) introduce createHistogram (James M Snell) #37155 process: * (SEMVER-MINOR) add api to enable source-maps programmatically (legendecas) #39085 * (SEMVER-MINOR) add `'worker'` event (James M Snell) #38659 * (SEMVER-MINOR) add direct access to rss without iterating pages (Adrien Maret) #34291 readline: * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) #37932 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 repl: * (SEMVER-MINOR) add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) #37246 src: * (SEMVER-MINOR) call overload ctor from the original ctor (Darshan Sen) #39768 * (SEMVER-MINOR) add a constructor overload for CallbackScope (Darshan Sen) #39768 * (SEMVER-MINOR) allow to negate boolean CLI flags (Michaël Zasso) #39023 * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) #33010 * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 * (SEMVER-MINOR) add maybe versions of EmitExit and EmitBeforeExit (Anna Henningsen) #35486 stream: * (SEMVER-MINOR) add readableDidRead if has been read from (Robert Nagy) #39589 * (SEMVER-MINOR) pipeline accept Buffer as a valid first argument (Nitzan Uziely) #37739 tls: * (SEMVER-MINOR) allow reading data into a static buffer (Andrey Pechkurov) #35753 tools: * (SEMVER-MINOR) add `Worker` to type-parser (James M Snell) #38659 url: * (SEMVER-MINOR) expose urlToHttpOptions utility (Yongsheng Zhang) #35960 util: * (SEMVER-MINOR) expose toUSVString (Robert Nagy) #39814 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) #33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) #33807 worker: * (SEMVER-MINOR) add setEnvironmentData/getEnvironmentData (James M Snell) #37486 PR-URL: #39990
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Sep 28, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 28, 2021
Copy link
Copy Markdown
|
I believe this reintroduced a problem that was fixed in this merge request (nodejs/node-core-utils#535) relating to downloading a corrupted binary zip file as text, as introduced in this merge request (#37294) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Thanks. I cherry-picked #37294 to v14.x-staging |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2021-09-28, Version 14.18.0 'Fermium' (LTS), @targos
Notable Changes
Commits
Semver-minor commits
Semver-patch commits
Documentation commits
Other commits