FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace "inspector-cli" with "debugger" by Trott · Pull Request #39156 · nodejs/node · GitHub

/ node Public

test: replace "inspector-cli" with "debugger" - #39156

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:finally
Jun 28, 2021
Merged

test: replace "inspector-cli" with "debugger"#39156
Trott merged 1 commit into
nodejs:masterfrom
Trott:finally

Conversation

Trott commented Jun 26, 2021

Copy link
Copy Markdown
Member

When I moved node-inspect into core, I called a lot of things
inspector-cli that really should have been debugger. This is the
last of them to be renamed.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2021
github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2021

Copy link
Copy Markdown
Collaborator

When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: nodejs#39156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott commented Jun 28, 2021

Copy link
Copy Markdown
Member Author

Landed in 9cdac42

Trott merged commit 9cdac42 into nodejs:master Jun 28, 2021
Trott deleted the finally branch June 28, 2021 13:28
targos pushed a commit that referenced this pull request Jul 11, 2021
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: #39156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: #39156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL