doc: fixed a missing backtick which broke the styling - #38260
Merged
aduh95 merged 1 commit intoApr 17, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benjamingr
approved these changes
Apr 16, 2021
Linkgoron
approved these changes
Apr 16, 2021
aduh95
approved these changes
Apr 16, 2021
Copy link
Copy Markdown
Contributor
|
Fast-track? |
Sorry, something went wrong.
richardlau
reviewed
Apr 16, 2021
Comment thread
doc/api/fs.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We seem to be stylizing "{...} object" without backticks? cc @nodejs/documentation
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yes, removing the backticks makes it a link, which would be preferable IMHO.
Suggested change
| The callback gets two arguments `(err, stats)` where `stats` is a {`fs.Stats`} | |
| The callback gets two arguments `(err, stats)` where `stats` is a {fs.Stats} |
Sorry, something went wrong.
aduh95
approved these changes
Apr 17, 2021
cjihrig
approved these changes
Apr 17, 2021
RaisinTen
approved these changes
Apr 17, 2021
PR-URL: nodejs#38260 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Contributor
|
Landed in 7d688d4. Thanks for the contribution :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Welcome! It was nothing. I can really feel the GitHub community after being able to contribute to Node.js. 😄 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #38260 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38257