FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: consolidate email addresses for some individuals with multiple AUTHORS entries by Trott · Pull Request #39651 · nodejs/node · GitHub

/ node Public

meta: consolidate email addresses for some individuals with multiple AUTHORS entries - #39651

Closed
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:mm
Closed

meta: consolidate email addresses for some individuals with multiple AUTHORS entries#39651
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:mm

Conversation

Trott commented Aug 3, 2021

Copy link
Copy Markdown
Member

@szmarczak @tadjik1 @MarshallOfSound Please let me know if I guessed at the wrong email to keep.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 3, 2021

szmarczak commented Aug 3, 2021
edited
Loading

Copy link
Copy Markdown
Member

You can keep the gmail one, but it doesn't matter so it's good with both as well :)

Comment thread .mailmap
Scott Blomquist <github@scott.blomqui.st> <sblom@microsoft.com>
Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com>
Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net>
Sergey Zelenov <mail@zelenov.su> <sergey.zelenov@getyourguide.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please keep only @zelenov.su, thanks!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please keep only @zelenov.su, thanks!

Thanks.

Just in case it's not clear what's going on here: This .mailmap file entry results in git and other tools treating all instances of the other email address as the same as the @zelenov.su address, which is why the other address is removed from the AUTHORS file in this pull request. The script that generates the AUTHORS file refers to .mailmap to figure out what email address to use for people that have more than one email in the git history.

So I think we're all set.

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2021

Copy link
Copy Markdown
Contributor

Landed in a1fac5b...54559b8

github-actions Bot closed this Aug 10, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 10, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 10, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Aug 10, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39651
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott deleted the mm branch September 25, 2022 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL