Updating upload.zip to be an uncorrupted version of the file - #37294
Updating upload.zip to be an uncorrupted version of the file#37294gziskind wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
The file was copied using git node wpt so maybe there's a bug in that command for binary files. /cc @joyeecheung |
Sorry, something went wrong.
Seems like a bug (or I'm not understanding the command). rm -rf test/fixtures/wpt/FileAPI && git node wpt FileAPI reports that FileAPI is up to date. 🤔 |
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
In the meantime, I've confirmed that this file is correct. Puzzling that the test would pass with an invalid file, but maybe we don't run it or it's marked as skipped or whatever.
Sorry, something went wrong.
Sorry, something went wrong.
We probably don't run the test that uses this file. Currently we pull the FileAPI tests only to run the ones that test the Blob API. |
Sorry, something went wrong.
You'd need to remove the hash in test/fixtures/wpt/versions.json - the command only checks the JSON to see if the data is up-to-date. I think the file was probably corrupted because it wasn't downloaded properly during the first update? |
Sorry, something went wrong.
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
|
PR to fix git node wpt: nodejs/node-core-utils#535 |
Sorry, something went wrong.
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
|
Just for my knowledge, when would this get rolled into a release if its been merged into master? |
Sorry, something went wrong.
Since it's a patch-fix, it will probably be in the next 15.x release, probably two weeks or so from now. Of course, since it's a test, it won't affect end users running node. But you'll see an entry in the changelog. |
Sorry, something went wrong.
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
There are binary files in the WPT repository and downloading them as text corrupts them. Refs: nodejs/node#37294
I noticed that the file in question seemed to be corrupted and could not be unzipped. The original source of the file was copied from https://github.com/web-platform-tests/wpt/blob/master/FileAPI/filelist-section/support/upload.zip, so i replaced the version in the node repository with the original version of the file and confirmed that it was able to be unzipped.