test: update error message keywords - #39826
Closed
leeight wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file`
Copy link
Copy Markdown
Contributor
Author
|
The failed error message is: 'dlopen(/xxx/node/test/fixtures/module-loading-error.node, 0x0001): tried: '/xxx/node/test/fixtures/module-loading-error.node' (not a mach-o file), '/usr/local/lib/module-loading-error.node' (no such file), '/usr/lib/module-loading-error.node' (no such file)' |
Sorry, something went wrong.
tniessen
approved these changes
Aug 21, 2021
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
cc @nodejs/platform-macos
Sorry, something went wrong.
cjihrig
approved these changes
Aug 21, 2021
richardlau
approved these changes
Aug 21, 2021
Copy link
Copy Markdown
Member
|
This isn't currently failing on our CI -- I guess this is particular to new versions of macOS? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
@richardlau I upgrade to macOS Monterey and run into this issue. |
Sorry, something went wrong.
targos
approved these changes
Aug 22, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Aug 22, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
XadillaX
approved these changes
Aug 26, 2021
jasnell
pushed a commit
that referenced
this pull request
Aug 26, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
targos
pushed a commit
that referenced
this pull request
Sep 1, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This testcase failed on Apple Silicon M1, add the error message pattern:
not a mach-o file