FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add gyp as owner of gyp files and tools/gyp by mmarchini · Pull Request #34847 · nodejs/node · GitHub

/ node Public

meta: add gyp as owner of gyp files and tools/gyp - #34847

Merged
gengjiawen merged 3 commits into
nodejs:masterfrom
mmarchini:codeowners-gyp
Aug 20, 2021
ConversationCommits (3)ChecksFiles changed
Merged

meta: add gyp as owner of gyp files and tools/gyp#34847
gengjiawen merged 3 commits into
nodejs:masterfrom
mmarchini:codeowners-gyp

Conversation

mmarchini commented Aug 19, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 19, 2020 •
edited by mmarchini
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 19, 2020

mmarchini commented Aug 19, 2020

Copy link
Copy Markdown
Contributor Author

cc @nodejs/gyp is it ok to add you as owner of gyp files?

jasnell commented Aug 19, 2020

Copy link
Copy Markdown
Member

Likely should also include @nodejs/build

mmarchini commented Aug 19, 2020

Copy link
Copy Markdown
Contributor Author

Not sure, maybe @nodejs/build-files (which I can do on a follow up PR since there are other files like ./configure and Makefile which should be added)? @nodejs/build is so noisy it might not be worth to have as codeowner.

mmarchini commented Aug 19, 2020

Copy link
Copy Markdown
Contributor Author

lol linter is failing (and I used a linter locally to check those exact lines 😅). Will figure out before landing, but the idea is to have @nodejs/gyp as owner for all gyp file changes in this repo.

richardlau commented Aug 19, 2020

Copy link
Copy Markdown
Member

Is

node/.github/CODEOWNERS

Lines 1 to 6 in 6f0b87d

# Node.js Project Codeowners
# 1. Codeowners must always be teams, never individuals
# 2. Each codeowner team should contain at least one TSC member
# 3. PRs touching any code with a codeowner must be signed off by at least one
# person on the code owner team.
still accurate? If so there are no TSC members in the gyp team.

mmarchini commented Aug 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Nice catch, I didn't realize that. Is that something we still want to enforce? It's probably a leftover from the first codeowners attempt a while back.

gengjiawen commented Aug 20, 2020

Copy link
Copy Markdown
Member

cc @nodejs/gyp is it ok to add you as owner of gyp files?

cc @targos looks like you are not in this group.

ryzokuken approved these changes Aug 20, 2020
View reviewed changes

ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cc @nodejs/gyp is it ok to add you as owner of gyp files?

Yes! Thank you.

mcollina approved these changes Aug 20, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ryzokuken commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

P.S. I added @mmarchini to @nodejs/gyp so now we do have a TSC member on the team, it would be nice to have @targos on there too, if they are willing.

targos commented Aug 20, 2020

Copy link
Copy Markdown
Member

Thanks, I added myself to the team :)

This comment has been minimized.

Sign in to view

mmarchini commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

#34847 (comment)

gengjiawen reviewed Aug 21, 2020
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
Trott closed this Aug 22, 2020
richardlau reopened this Aug 22, 2020

Trott commented Aug 22, 2020

Copy link
Copy Markdown
Member

(Sorry about the accidental close. Wrong window!)

aduh95 commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

@mmarchini This needs a rebase.

gengjiawen merged commit 279162c into nodejs:master Aug 20, 2021
targos pushed a commit that referenced this pull request Aug 22, 2021
meta: add gyp as owner of gyp files and tools/gyp
158d446 
Co-authored-by: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #34847
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Aug 25, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
meta: add gyp as owner of gyp files and tools/gyp
8f8f528 
Co-authored-by: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #34847
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
+1 more reviewer
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL