tools: upgrade highlight.js to version 11.0.1 - #39032
Closed
aduh95 wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Did you make a diff of the out/doc directory between master and this? When I looked at the breaking changes, it seemed we would be affected by the removal of coffeescript highlighting, |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
CoffeeScript is removed from highlight.min.js (so the browser build, not the CommonJS one). I can confirm it's still in the npm package, and that all coffee code snippets are still highlighted. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Jun 17, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 26, 2021
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems our tooling is not affected by any of the breaking changes highlight.js v11, I think there's no reason to keep using v10.x.
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md