FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add support for import assertions in linter by aduh95 · Pull Request #39924 · nodejs/node · GitHub

/ node Public

tools: add support for import assertions in linter - #39924

Closed
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:import-assertions-linter
ConversationCommits (2)ChecksFiles changed
Closed

tools: add support for import assertions in linter#39924
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:import-assertions-linter

Conversation

aduh95 commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Necessary for #39921.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 28, 2021
aduh95 mentioned this pull request Aug 28, 2021
Closed
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 28, 2021
Trott approved these changes Aug 31, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber stamp LGTM

jasnell commented Sep 3, 2021

Copy link
Copy Markdown
Member

Landed in f26c2ce

jasnell closed this Sep 3, 2021
jasnell pushed a commit that referenced this pull request Sep 3, 2021
tools: add support for import assertions in linter
f26c2ce 
PR-URL: #39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
aduh95 deleted the import-assertions-linter branch September 3, 2021 14:51
targos pushed a commit that referenced this pull request Sep 4, 2021
tools: add support for import assertions in linter
7b2bebb 
PR-URL: #39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
targos pushed a commit that referenced this pull request Sep 6, 2021
tools: add support for import assertions in linter
d92bd9a 
PR-URL: #39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos mentioned this pull request Sep 6, 2021
Merged
aduh95 restored the import-assertions-linter branch October 14, 2021 15:29
tools: add support for import assertions in linter
2cbfc9f 
PR-URL: nodejs#39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

aduh95 commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

This was (erroneously I think) removed in #40394, re-opening.

aduh95 reopened this Oct 14, 2021
aduh95 force-pushed the import-assertions-linter branch from f6e527b to 2cbfc9f Compare October 14, 2021 15:34

targos commented Oct 14, 2021

Copy link
Copy Markdown
Member

It seems like you're right, but if nothing breaks when we remove it, doesn't it prove that we don't need it (yet) ?

aduh95 commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

It seems like you're right, but if nothing breaks when we remove it, doesn't it prove that we don't need it (yet) ?

Fair, added a test.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2021

nodejs-github-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40306/

GeoffreyBooth approved these changes Oct 14, 2021
View reviewed changes

GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need this in order to land #40250.

nodejs-github-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40308/

github-actions Bot mentioned this pull request Oct 15, 2021
Open
23 tasks

nodejs-github-bot commented Oct 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40310/

nodejs-github-bot commented Oct 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40311/

nodejs-github-bot commented Oct 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40315/

nodejs-github-bot commented Oct 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40316/

nodejs-github-bot commented Oct 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40319/

This was referenced Oct 16, 2021
Open
Open

nodejs-github-bot commented Oct 17, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40333/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2021

github-actions Bot commented Oct 17, 2021

Copy link
Copy Markdown
Contributor

Landed in cbc7b5d...f5e9486

github-actions Bot closed this Oct 17, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 17, 2021
tools: add support for import assertions in linter
f5e9486 
PR-URL: #39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
aduh95 deleted the import-assertions-linter branch October 17, 2021 18:56
This was referenced Oct 18, 2021
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 4, 2021
tools: add support for import assertions in linter
abf3b84 
PR-URL: #39924
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
Trott Trott approved these changes
watilde watilde approved these changes
Lxxyx Lxxyx approved these changes
+2 more reviewers
bmeck bmeck approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL