FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 8.0.0 by Trott · Pull Request #40394 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 8.0.0 - #40394

Merged
Trott merged 7 commits into
nodejs:masterfrom
Trott:eslint-update-8.0.0
Oct 12, 2021
ConversationCommits (7)ChecksFiles changed
Merged

tools: update ESLint to 8.0.0#40394
Trott merged 7 commits into
nodejs:masterfrom
Trott:eslint-update-8.0.0

Conversation

Trott commented Oct 10, 2021

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 10, 2021
Trott force-pushed the eslint-update-8.0.0 branch 4 times, most recently from ee9dfb1 to 32b353d Compare October 10, 2021 01:44
Trott mentioned this pull request Oct 10, 2021
Closed
Mesteery added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 10, 2021
aduh95 approved these changes Oct 10, 2021
View reviewed changes

aduh95 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

Trott force-pushed the eslint-update-8.0.0 branch from 38e6e18 to cf7749f Compare October 10, 2021 14:20

Trott commented Oct 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

I agree. Squashed.

lpinca approved these changes Oct 11, 2021
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
Trott added 7 commits October 11, 2021 18:37
tools: fix ESLint update scripts
0a1b399 
Changes to the npm dependency in the core repo require changes to
update-eslint.sh and update-bable-eslint.sh.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: prepare ESLint rules for 8.0.0 requirements
dd8e219 
PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: update ESLint to 8.0.0
8ca76eb 
PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: remove @babel/plugin-syntax-top-level-await
a6fd39f 
ESLint 8.0.0 introduced support for top level await, so
@babel/plugin-syntax-top-level-await is no longer necessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: remove @bable/plugin-syntax-class-properties
b39db95 
ESLint 8.0.0 makes the plugin unnecessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: remove @babel/plugin-syntax-import-assertions
43c780e 
As of ESLint 8.0.0 at least, this plugin is unnecessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tools: udpate @babel/eslint-parser
012152d 
Remove unused plugins and update @babel/eslint-parser

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott force-pushed the eslint-update-8.0.0 branch from cf7749f to 012152d Compare October 12, 2021 01:38

Trott commented Oct 12, 2021

Copy link
Copy Markdown
Member Author

Landed in 40db88b...012152d

Trott merged commit 012152d into nodejs:master Oct 12, 2021
Trott deleted the eslint-update-8.0.0 branch October 12, 2021 01:40
Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: fix ESLint update scripts
282b6eb 
Changes to the npm dependency in the core repo require changes to
update-eslint.sh and update-bable-eslint.sh.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: prepare ESLint rules for 8.0.0 requirements
43b97c7 
PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: update ESLint to 8.0.0
d9157aa 
PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: remove @babel/plugin-syntax-top-level-await
d6a99b7 
ESLint 8.0.0 introduced support for top level await, so
@babel/plugin-syntax-top-level-await is no longer necessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: remove @bable/plugin-syntax-class-properties
b72d693 
ESLint 8.0.0 makes the plugin unnecessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: remove @babel/plugin-syntax-import-assertions
3611073 
As of ESLint 8.0.0 at least, this plugin is unnecessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
tools: udpate @babel/eslint-parser
50f91ab 
Remove unused plugins and update @babel/eslint-parser

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
aduh95 mentioned this pull request Oct 14, 2021
Closed
richardlau mentioned this pull request Oct 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL